You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/08 13:13:49 UTC

[GitHub] [incubator-doris] BiteTheDDDDt opened a new pull request, #8930: [Enhancement][Regression-Test] enhancement for regression-test framework

BiteTheDDDDt opened a new pull request, #8930:
URL: https://github.com/apache/incubator-doris/pull/8930

   # Proposed changes
   
   Issue Number: close #8729
   
   ## Problem Summary:
   
   Describe the overview of changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes/No/I Don't know)
   2. Has unit tests been added: (Yes/No/No Need)
   3. Has document been added or modified: (Yes/No/No Need)
   4. Does it need to update dependencies: (Yes/No)
   5. Are there any changes that cannot be rolled back: (Yes/No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] HappenLee merged pull request #8930: [Enhancement][Regression-Test] enhancement for regression-test framework

Posted by GitBox <gi...@apache.org>.
HappenLee merged PR #8930:
URL: https://github.com/apache/incubator-doris/pull/8930


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] 924060929 commented on pull request #8930: [Enhancement][Regression-Test] enhancement for regression-test framework

Posted by GitBox <gi...@apache.org>.
924060929 commented on PR #8930:
URL: https://github.com/apache/incubator-doris/pull/8930#issuecomment-1097675748

   +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8930: [Enhancement][Regression-Test] enhancement for regression-test framework

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8930:
URL: https://github.com/apache/incubator-doris/pull/8930#issuecomment-1098680719

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] 924060929 commented on a diff in pull request #8930: [Enhancement][Regression-Test] enhancement for regression-test framework

Posted by GitBox <gi...@apache.org>.
924060929 commented on code in PR #8930:
URL: https://github.com/apache/incubator-doris/pull/8930#discussion_r847164901


##########
regression-test/framework/src/main/groovy/org/apache/doris/regression/util/JdbcUtils.groovy:
##########
@@ -18,37 +18,40 @@
 package org.apache.doris.regression.util
 
 import com.google.common.collect.ImmutableList
+import org.apache.doris.regression.util.Metaholder
 
 import java.sql.Connection
 import java.sql.ResultSet
+import java.sql.ResultSetMetaData
 
 class JdbcUtils {
-    static List<List<Object>> executeToList(Connection conn, String sql) {
+    static List<List<Object>> executeToList(Connection conn, String sql, Metaholder holder) {
         conn.prepareStatement(sql).withCloseable { stmt ->

Review Comment:
   suggest `new Metaholder` in `JdbcUtils` and return, and you can extract the interest metadata out of the `Connection` life cycle safely.
   
   e.g.
   
   ```groovy
   class Metadata {
     public final List<String> columnNames;
     public final List<String> columnTypes;
   }
   
   static Tuple2<List<List<Object>>, Metadata> executeToList(Connection conn, String sql) {
     def metadata = new Metadata()
     resultList = ...
     metadata.columnNames = ...
     metadata.columnTypes = ...
     return [resultList, metadata]
   }
   ```
   then, you can take result by this code
   ```groovy
   def (result, metadata) = JdbcUtils.executeToList(connnection, sql)
   ```



##########
regression-test/framework/src/main/groovy/org/apache/doris/regression/util/OutputUtils.groovy:
##########
@@ -44,9 +53,36 @@ class OutputUtils {
         return writer.toString()
     }
 
+    static String checkCell(String info, int line, String expect_cell, String real_cell, String data_type) {
+        if(data_type == "FLOAT" || data_type == "DOUBLE") {

Review Comment:
   suggest change to camel case



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] BiteTheDDDDt commented on a diff in pull request #8930: [Enhancement][Regression-Test] enhancement for regression-test framework

Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #8930:
URL: https://github.com/apache/incubator-doris/pull/8930#discussion_r848179292


##########
regression-test/framework/src/main/groovy/org/apache/doris/regression/util/JdbcUtils.groovy:
##########
@@ -18,37 +18,40 @@
 package org.apache.doris.regression.util
 
 import com.google.common.collect.ImmutableList
+import org.apache.doris.regression.util.Metaholder
 
 import java.sql.Connection
 import java.sql.ResultSet
+import java.sql.ResultSetMetaData
 
 class JdbcUtils {
-    static List<List<Object>> executeToList(Connection conn, String sql) {
+    static List<List<Object>> executeToList(Connection conn, String sql, Metaholder holder) {
         conn.prepareStatement(sql).withCloseable { stmt ->

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] 924060929 commented on pull request #8930: [Enhancement][Regression-Test] enhancement for regression-test framework

Posted by GitBox <gi...@apache.org>.
924060929 commented on PR #8930:
URL: https://github.com/apache/incubator-doris/pull/8930#issuecomment-1097675747

   +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org