You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/08/19 10:25:40 UTC
[GitHub] [camel-quarkus] djcoleman opened a new pull request, #4020: Fix #3389: geocoder test returned wrong city
djcoleman opened a new pull request, #4020:
URL: https://github.com/apache/camel-quarkus/pull/4020
The Nominatim test was failing due to the city returned from the `loadLatLong` test having changed to _City of New York_. As suggested in the comments, I changed the coordinates from New York to a street address in San Francisco instead, which hopefully won't suffer from name changes.
The mock data for Google and Nominatim requests was also updated.
Further info in the ticket: https://github.com/apache/camel-quarkus/issues/3389
[x] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[x] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[x] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[x] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[x] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on pull request #4020: Fix #3389: geocoder test returned wrong city
Posted by GitBox <gi...@apache.org>.
zbendhiba commented on PR #4020:
URL: https://github.com/apache/camel-quarkus/pull/4020#issuecomment-1220869060
Thanks @djcoleman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger merged pull request #4020: Fix #3389: geocoder test returned wrong city
Posted by GitBox <gi...@apache.org>.
aldettinger merged PR #4020:
URL: https://github.com/apache/camel-quarkus/pull/4020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org