You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ho...@apache.org on 2019/03/11 17:07:13 UTC
[lucene-solr] branch branch_8x updated: SOLR-13300:
DistributedFacetExistsSmallTest should not attempt to compare results of a
query that is known to differ in behavior in distributed mode
This is an automated email from the ASF dual-hosted git repository.
hossman pushed a commit to branch branch_8x
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git
The following commit(s) were added to refs/heads/branch_8x by this push:
new 44ff1c0 SOLR-13300: DistributedFacetExistsSmallTest should not attempt to compare results of a query that is known to differ in behavior in distributed mode
44ff1c0 is described below
commit 44ff1c0ef9fb184aebc51e0c995ccaeb610c0929
Author: Chris Hostetter <ho...@apache.org>
AuthorDate: Mon Mar 11 10:02:46 2019 -0700
SOLR-13300: DistributedFacetExistsSmallTest should not attempt to compare results of a query that is known to differ in behavior in distributed mode
(cherry picked from commit 7eb728a611a5cad82e44bd662294d682353a2ccb)
---
.../handler/component/DistributedFacetExistsSmallTest.java | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/solr/core/src/test/org/apache/solr/handler/component/DistributedFacetExistsSmallTest.java b/solr/core/src/test/org/apache/solr/handler/component/DistributedFacetExistsSmallTest.java
index 58c5a2e..0c381e9 100644
--- a/solr/core/src/test/org/apache/solr/handler/component/DistributedFacetExistsSmallTest.java
+++ b/solr/core/src/test/org/apache/solr/handler/component/DistributedFacetExistsSmallTest.java
@@ -125,7 +125,9 @@ public class DistributedFacetExistsSmallTest extends BaseDistributedSearchTestCa
params.add("facet.prefix", prefixes[rand.nextInt(prefixes.length)]);
}
- if (rand.nextInt(100) < 20) {
+ // don't bother trying to to test facet.missing=true + facet.limit=0
+ // distrib & non-distrib are known to behave differently in this
+ if (rand.nextInt(100) < 20 && 0 < params.getInt("facet.limit", 100)) {
params.add("facet.missing", "true");
}
@@ -133,13 +135,7 @@ public class DistributedFacetExistsSmallTest extends BaseDistributedSearchTestCa
params.add("facet.mincount", rand.nextBoolean() ? "0": "1" );
}
- final boolean shardRespondsWithMissingEvenLimitIsZero =
- params.getBool("facet.missing", false) && params.getInt("facet.limit", 100)==0;
-
query(params);
- if (shardRespondsWithMissingEvenLimitIsZero ) {
- handle.remove(null);
- }
}
private void checkInvalidMincount() throws SolrServerException, IOException {