You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/04/15 00:34:10 UTC
[GitHub] [cordova-ios] PlanetaryCode opened a new pull request #825: Fix two
compile-time type warnings and simplify code by using auto boxing of
NSNumber.
PlanetaryCode opened a new pull request #825: Fix two compile-time type warnings and simplify code by using auto boxing of NSNumber.
URL: https://github.com/apache/cordova-ios/pull/825
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
I hate disregarded warnings at compile time.
### Description
<!-- Describe your changes in detail -->
Existing code was converting to NSNumber with wrong init method for the type.
Rather than change the method called I switched to auto boxing the values which automatically does the right thing in less code.
### Testing
<!-- Please describe in detail how you tested your changes. -->
Ran npm test
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] dpogue merged pull request #825: (iOS) Fix two
compile-time type warnings and simplify code by using auto boxing of
NSNumber.
Posted by GitBox <gi...@apache.org>.
dpogue merged pull request #825: (iOS) Fix two compile-time type warnings and simplify code by using auto boxing of NSNumber.
URL: https://github.com/apache/cordova-ios/pull/825
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io edited a comment on issue #825: (iOS) Fix
two compile-time type warnings and simplify code by using auto boxing of
NSNumber.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #825: (iOS) Fix two compile-time type warnings and simplify code by using auto boxing of NSNumber.
URL: https://github.com/apache/cordova-ios/pull/825#issuecomment-613752064
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/825?src=pr&el=h1) Report
> Merging [#825](https://codecov.io/gh/apache/cordova-ios/pull/825?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/fca1f3b596d0ac64096c00f25e5ff5a007b267e4&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-ios/pull/825?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #825 +/- ##
=======================================
Coverage 74.20% 74.20%
=======================================
Files 13 13
Lines 1849 1849
=======================================
Hits 1372 1372
Misses 477 477
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/825?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/825?src=pr&el=footer). Last update [fca1f3b...226b4ff](https://codecov.io/gh/apache/cordova-ios/pull/825?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io commented on issue #825: (iOS) Fix two
compile-time type warnings and simplify code by using auto boxing of
NSNumber.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #825: (iOS) Fix two compile-time type warnings and simplify code by using auto boxing of NSNumber.
URL: https://github.com/apache/cordova-ios/pull/825#issuecomment-613752064
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/825?src=pr&el=h1) Report
> Merging [#825](https://codecov.io/gh/apache/cordova-ios/pull/825?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/fca1f3b596d0ac64096c00f25e5ff5a007b267e4&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-ios/pull/825?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #825 +/- ##
=======================================
Coverage 74.20% 74.20%
=======================================
Files 13 13
Lines 1849 1849
=======================================
Hits 1372 1372
Misses 477 477
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/825?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/825?src=pr&el=footer). Last update [fca1f3b...226b4ff](https://codecov.io/gh/apache/cordova-ios/pull/825?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org