You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/04/05 22:29:20 UTC

[GitHub] [kafka] hachikuji commented on pull request #10481: KAFKA-12619; Raft leader should expose hw only after committing LeaderChange

hachikuji commented on pull request #10481:
URL: https://github.com/apache/kafka/pull/10481#issuecomment-813686724


   @guozhangwang Thanks for the quick comment. I did consider that. I can't say I had a particularly strong reason to reject it, but ultimately I convinced myself that modifying the existing check was good enough and probably simpler. The only invariant that we need to protect is that all records appended in the leader's epoch actually carry the right epoch tag. The refactor proposed here may even give us a stronger way to enforce the invariant: https://github.com/apache/kafka/pull/10480/files. What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org