[GitHub] [airflow] potiuk opened a new pull request #10517: Sets default timeout for the job waiting for images

[GitBox <gi...@apache.org>]

potiuk opened a new pull request #10517:
URL: https://github.com/apache/airflow/pull/10517


   In normal circumstances those jobs will wait for a short time
   (4-15 minutes depenfding on the state of the base image).
   However there might be some cases when there are a lot of jobs
   or when there is some queueing problems in GitHub that
   the "Build Images" job will be queued and not start quickly.
   
   This happened on 24th of August 2020 for example when several
   jobs failed because the "Build Image" was queued and only
   run after the "CI Build" job timed out.
   
   Usually those situations tends to be resolved by GitHub support
   or they resolve themselves as the jobs will be finishing and
   freing the queue. However in those cases we should give the
   waiting job as much time as GitHub Action allows by default
   for the job to run (360 minutes). This is no harm - we can
   alwayc cancel those jobs manually and they are just two
   jobs running so it should not cause any problem.
   
   Note that if someone would see that the job is running for
   a long time - the contributor will likely push amended
   commit and it will also cancel such waiting job, so
   this is even less likely to have long runnning waiting jobs.
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #10517: Sets default timeout for the job waiting for images

[GitBox <gi...@apache.org>]

potiuk merged pull request #10517:
URL: https://github.com/apache/airflow/pull/10517


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #10517: Sets default timeout for the job waiting for images

[GitBox <gi...@apache.org>]

potiuk commented on pull request #10517:
URL: https://github.com/apache/airflow/pull/10517#issuecomment-679263489


   I noticed today that we had some period of time when our queue of builds temporary decreased (we had just few jobs running in parallel) - this caused a few "CI Builds" to timeout , but this was not really needed - the queue caught up later and started to run with the usual speed, so if we had longer timeout, the jobs would eventually succeed. 
   
   I removed the limit to the default 360 minutes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org