You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/12/09 14:40:29 UTC
[GitHub] [cloudstack] GabrielBrascher opened a new pull request #5762: Enhance log message in FirstFitPlanner
GabrielBrascher opened a new pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762
### Description
When cluster reached capacity threshold log message is:
`"capacity threshold defined at each cluster/ at global value for capacity Type : 0"`
Admins hardly remember the Capacity Type and it can take a while to look at which is the resource for the respective ID.
This PR adds a log message pointing to the capacity name (e.g. Memory / CPU) as well as global settings parameter name and value to be looked at.
Additionally, this PR also proposes to change the log message from DEBUG to Warning, as it gives relevant information in case of exceptions, and might enforce production environments to have log level at debugging instead of info.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#issuecomment-991763446
hm, none of the travfis runs succeeded :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#issuecomment-991132588
@DaanHoogland I think so.
Unless` ClusterCPUCapacityDisableThreshold.value()` could be null. I might need to add a validation in such a case to not get a log message resulting in NPE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#discussion_r772510749
##########
File path: server/src/main/java/com/cloud/deploy/FirstFitPlanner.java
##########
@@ -367,8 +372,11 @@ protected void removeClustersCrossingThreshold(List<Long> clusterListForVmAlloca
// Remove clusters crossing disabled threshold
clusterListForVmAllocation.removeAll(clustersCrossingThreshold);
- s_logger.debug("Cannot allocate cluster list " + clustersCrossingThreshold.toString() + " for vm creation since their allocated percentage" +
- " crosses the disable capacity threshold defined at each cluster/ at global value for capacity Type : " + capacity + ", skipping these clusters");
+ String warnMessageForClusterReachedCapacityThreshold = String.format(
+ "Cannot allocate cluster list %s for vm creation since their allocated percentage crosses the disable capacity threshold defined at each cluster at"
Review comment:
Thanks @GutoVeronezi. Updated it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#issuecomment-998089537
@sureshanaparti I have just changed the base branch from `main` to `4.16`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#discussion_r765920335
##########
File path: server/src/main/java/com/cloud/deploy/FirstFitPlanner.java
##########
@@ -367,8 +372,11 @@ protected void removeClustersCrossingThreshold(List<Long> clusterListForVmAlloca
// Remove clusters crossing disabled threshold
clusterListForVmAllocation.removeAll(clustersCrossingThreshold);
- s_logger.debug("Cannot allocate cluster list " + clustersCrossingThreshold.toString() + " for vm creation since their allocated percentage" +
- " crosses the disable capacity threshold defined at each cluster/ at global value for capacity Type : " + capacity + ", skipping these clusters");
+ String warnMessageForClusterReachedCapacityThreshold = String.format(
+ "Cannot allocate cluster list %s for vm creation since their allocated percentage crosses the disable capacity threshold defined at each cluster at"
+ + " global value [settings: %s, value: %s] for capacity Type : %s, skipping these clusters", clustersCrossingThreshold.toString(),
Review comment:
@DaanHoogland updated the code to fit with your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#issuecomment-993357653
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#issuecomment-998467351
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#issuecomment-998555538
Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#issuecomment-992239183
> @DaanHoogland I think so. Unless` ClusterCPUCapacityDisableThreshold.value()` could be null. I might need to add a validation in such a case to not get a log message resulting in NPE.
@GabrielBrascher as far as I know, we cannot update configurations with value type =Integer/Long/Float to null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#issuecomment-993358254
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#discussion_r768444264
##########
File path: server/src/main/java/com/cloud/deploy/FirstFitPlanner.java
##########
@@ -367,8 +372,11 @@ protected void removeClustersCrossingThreshold(List<Long> clusterListForVmAlloca
// Remove clusters crossing disabled threshold
clusterListForVmAllocation.removeAll(clustersCrossingThreshold);
- s_logger.debug("Cannot allocate cluster list " + clustersCrossingThreshold.toString() + " for vm creation since their allocated percentage" +
- " crosses the disable capacity threshold defined at each cluster/ at global value for capacity Type : " + capacity + ", skipping these clusters");
+ String warnMessageForClusterReachedCapacityThreshold = String.format(
+ "Cannot allocate cluster list %s for vm creation since their allocated percentage crosses the disable capacity threshold defined at each cluster at"
+ + " global value [settings: %s, value: %s] for capacity Type : %s, skipping these clusters", clustersCrossingThreshold.toString(),
Review comment:
Thanks for the review @sureshanaparti.
I've updated it.
- from: `... global value [settings: %s, value: %s] for...`;
- to: `... Global Settings Configuration [name: %s, value: %s] for...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#issuecomment-998959560
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#issuecomment-999242459
<b>Trillian test result (tid-2710)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32399 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5762-t2710-kvm-centos7.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#issuecomment-998467100
> @sureshanaparti I have just changed the base branch from `main` to `4.16`.
thanks @GabrielBrascher
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti removed a comment on pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
sureshanaparti removed a comment on pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#issuecomment-998467351
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#issuecomment-998783344
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#discussion_r768329384
##########
File path: server/src/main/java/com/cloud/deploy/FirstFitPlanner.java
##########
@@ -367,8 +372,11 @@ protected void removeClustersCrossingThreshold(List<Long> clusterListForVmAlloca
// Remove clusters crossing disabled threshold
clusterListForVmAllocation.removeAll(clustersCrossingThreshold);
- s_logger.debug("Cannot allocate cluster list " + clustersCrossingThreshold.toString() + " for vm creation since their allocated percentage" +
- " crosses the disable capacity threshold defined at each cluster/ at global value for capacity Type : " + capacity + ", skipping these clusters");
+ String warnMessageForClusterReachedCapacityThreshold = String.format(
+ "Cannot allocate cluster list %s for vm creation since their allocated percentage crosses the disable capacity threshold defined at each cluster at"
+ + " global value [settings: %s, value: %s] for capacity Type : %s, skipping these clusters", clustersCrossingThreshold.toString(),
Review comment:
```suggestion
+ " global value [setting: %s, value: %s] for capacity Type : %s, skipping these clusters", clustersCrossingThreshold.toString(),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#issuecomment-998468223
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on a change in pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#discussion_r768950456
##########
File path: server/src/main/java/com/cloud/deploy/FirstFitPlanner.java
##########
@@ -367,8 +372,11 @@ protected void removeClustersCrossingThreshold(List<Long> clusterListForVmAlloca
// Remove clusters crossing disabled threshold
clusterListForVmAllocation.removeAll(clustersCrossingThreshold);
- s_logger.debug("Cannot allocate cluster list " + clustersCrossingThreshold.toString() + " for vm creation since their allocated percentage" +
- " crosses the disable capacity threshold defined at each cluster/ at global value for capacity Type : " + capacity + ", skipping these clusters");
+ String warnMessageForClusterReachedCapacityThreshold = String.format(
+ "Cannot allocate cluster list %s for vm creation since their allocated percentage crosses the disable capacity threshold defined at each cluster at"
Review comment:
CLGTM, just have one suggestion:
```suggestion
"Cannot allocate cluster list %s for VM creation since their allocated percentage crosses the disable capacity threshold defined at each cluster at"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#discussion_r765863355
##########
File path: server/src/main/java/com/cloud/deploy/FirstFitPlanner.java
##########
@@ -367,8 +372,11 @@ protected void removeClustersCrossingThreshold(List<Long> clusterListForVmAlloca
// Remove clusters crossing disabled threshold
clusterListForVmAllocation.removeAll(clustersCrossingThreshold);
- s_logger.debug("Cannot allocate cluster list " + clustersCrossingThreshold.toString() + " for vm creation since their allocated percentage" +
- " crosses the disable capacity threshold defined at each cluster/ at global value for capacity Type : " + capacity + ", skipping these clusters");
+ String warnMessageForClusterReachedCapacityThreshold = String.format(
+ "Cannot allocate cluster list %s for vm creation since their allocated percentage crosses the disable capacity threshold defined at each cluster at"
+ + " global value [settings: %s, value: %s] for capacity Type : %s, skipping these clusters", clustersCrossingThreshold.toString(),
Review comment:
```suggestion
"Cannot allocate cluster list %s for vm creation since their allocated percentage crosses the disable capacity threshold defined at each cluster at"
+ " global value [settings: %s, value: %s] for capacity Type : %s, skipping these clusters", clustersCrossingThreshold.toString(),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#issuecomment-991763446
hm, none of the travfis runs succeeded :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti merged pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
sureshanaparti merged pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#issuecomment-998487220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#issuecomment-998487220
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 1970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#issuecomment-998523603
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#issuecomment-993699430
Hi @GabrielBrascher Is this PR good to go in 4.16.1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#issuecomment-993454315
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#issuecomment-998960325
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#issuecomment-998725284
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#issuecomment-998724372
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5762: Enhance log message in FirstFitPlanner
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5762:
URL: https://github.com/apache/cloudstack/pull/5762#issuecomment-998523339
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org