You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/06/12 11:13:40 UTC
[GitHub] [rocketmq] wuzhushijianle opened a new pull request, #4453: [ISSUE #4452]Optimize: reduce unnecessary codes in RemoteBrokerOffsetStore
wuzhushijianle opened a new pull request, #4453:
URL: https://github.com/apache/rocketmq/pull/4453
**Make sure set the target branch to `develop`**
## What is the purpose of the change
reduce unnecessary codes in RemoteBrokerOffsetStore
fix https://github.com/apache/rocketmq/issues/4452
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] wuzhushijianle closed pull request #4453: [ISSUE #4452]Optimize: reduce unnecessary codes in RemoteBrokerOffsetStore
Posted by GitBox <gi...@apache.org>.
wuzhushijianle closed pull request #4453: [ISSUE #4452]Optimize: reduce unnecessary codes in RemoteBrokerOffsetStore
URL: https://github.com/apache/rocketmq/pull/4453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ShannonDing commented on a diff in pull request #4453: [ISSUE #4452]Optimize: reduce unnecessary codes in RemoteBrokerOffsetStore
Posted by GitBox <gi...@apache.org>.
ShannonDing commented on code in PR #4453:
URL: https://github.com/apache/rocketmq/pull/4453#discussion_r895271605
##########
client/src/main/java/org/apache/rocketmq/client/consumer/store/RemoteBrokerOffsetStore.java:
##########
@@ -82,9 +82,8 @@ public long readOffset(final MessageQueue mq, final ReadOffsetType type) {
AtomicLong offset = this.offsetTable.get(mq);
if (offset != null) {
return offset.get();
- } else if (ReadOffsetType.READ_FROM_MEMORY == type) {
- return -1;
Review Comment:
offset will be got from remote broker if it was got failed in local offset table in MEMORY_FIRST_THEN_STORE model.
Just return -1 in READ_FROM_MEMORY model.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org