[GitHub] [trafficcontrol] hbeatty commented on a change in pull request #3418: Updates to ToDSCPCheck.pl

[GitBox <gi...@apache.org>]

hbeatty commented on a change in pull request #3418: Updates to ToDSCPCheck.pl
URL: https://github.com/apache/trafficcontrol/pull/3418#discussion_r269721278
 
 

 ##########
 File path: traffic_ops/app/bin/checks/ToDSCPCheck.pl
 ##########
 @@ -105,179 +111,231 @@
 
 my $check_name = $jconf->{check_name};
 if ( $check_name ne "DSCP" ) {
-   ERROR "This Check Extension is exclusively for DSCP.";
+   FATAL "FATAL This Check Extension is exclusively for DSCP.";
    print "\n\n";
    &help();
    exit(4);
 }
 
-
-TRACE( "force: " . $args{f} . "" );
-
-TRACE Dumper($jconf);
+DEBUG "DEBUG " . Dumper($jconf);
 my $b_url = $jconf->{base_url};
 Extensions::Helper->import();
 my $ext = Extensions::Helper->new( { base_url => $b_url, token => '91504CE6-8E4A-46B2-9F9F-FE7C15228498' } );
 
 my %ds_info           = ();
 my $jdeliveryservices = $ext->get( Extensions::Helper::DSLIST_PATH );
 
-# Get all the Deliver Services
+# Get all the Delivery Services
 foreach my $ds ( @{$jdeliveryservices} ) {
    $ds_info{ $ds->{id} } = $ds;
+
+   # Get the DS details and add the matchList
+   my $ds_details = $ext->get( '/api/1.2/deliveryservices/' . $ds->{id} );
+   #DEBUG "Debug matchList before push: " . Dumper($ds_details->[0]{matchList});
+   # The matchList was removed at one point and now it's back.
+   # Leaving this here for when that happens again.
+   #push( @{ $ds_info{ $ds->{id} }{matchList} }, @{ $ds_details->[0]{matchList} } );
+   #DEBUG "Debug matchList after push: " . Dumper($ds_info{ $ds->{id} }{matchList});
 
 Review comment:
   I would like to leave this in if someone breaks the API again.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services