[GitHub] [flink] carp84 commented on issue #10300: [FLINK-14926] [state backends] Make sure no resource leak of RocksObject

[GitBox <gi...@apache.org>]

carp84 commented on issue #10300: [FLINK-14926] [state backends] Make sure no resource leak of RocksObject
URL: https://github.com/apache/flink/pull/10300#issuecomment-562605849
 
 
   > Is the BloomFilter object large, would that be a problem?
   This is something I'm not that sure, need some time for investigation.
   
   > Remove the bloom filter from the predefined options.
   From the javadoc `SPINNING_DISK_OPTIMIZED_HIGH_MEM` is for better performance on regular spinning hard disks. If user is using this in production, I guess w/ and w/o bloom filter would make a big difference...
   
   > move away from the predefined options in 1.10
   I think the purpose of predefined options is not for resource management, but trying to supply an easy way of config for different use cases, especially for HDD_DISK, HDD_DISK+MEM, and FLASH_SSD. I would suggest a survey first in our ML before removing it.
   
   What do you think if we change `PredefinedOptions` from enum to some instantiated class and make the configuration unchanged? Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services