[GitHub] [hudi] xushiyan commented on a change in pull request #5099: [HUDI-3689] Fixing file scheme to local for TestHoodieRealTimeRecordReader

[GitBox <gi...@apache.org>]

xushiyan commented on a change in pull request #5099:
URL: https://github.com/apache/hudi/pull/5099#discussion_r832949341



##########
File path: hudi-hadoop-mr/src/test/java/org/apache/hudi/hadoop/realtime/TestHoodieRealtimeRecordReader.java
##########
@@ -104,11 +104,12 @@
   private Configuration hadoopConf;
 
   @BeforeEach
-  public void setUp() {
+  public void setUp() throws IOException {
     hadoopConf = HoodieTestUtils.getDefaultHadoopConf();
     baseJobConf = new JobConf(hadoopConf);
     baseJobConf.set(HoodieRealtimeConfig.MAX_DFS_STREAM_BUFFER_SIZE_PROP, String.valueOf(1024 * 1024));
-    fs = FSUtils.getFs(basePath.toString(), baseJobConf);

Review comment:
       you can simply do `basePath.toUri()` ? this was set by `@TempDir` so it's always `/tmp/xxx`. we don't need to check scheme




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org