[jira] [Commented] (CALCITE-5411) Update Spark Dialect to support ROLLUP & CUBE aggregate functions.

["Julian Hyde (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-5411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705692#comment-17705692 ] 

Julian Hyde commented on CALCITE-5411:
--------------------------------------

Thanks for this PR.

To be pedantic, {{ROLLUP}} and {{CUBE}} are not aggregate functions. (However, they are operators associated with aggregation and {{GROUP BY}}.)

> Update Spark Dialect to support ROLLUP & CUBE aggregate functions.
> ------------------------------------------------------------------
>
>                 Key: CALCITE-5411
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5411
>             Project: Calcite
>          Issue Type: Task
>    Affects Versions: 1.32.0
>            Reporter: Leonid Chistov
>            Assignee: Leonid Chistov
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.35.0
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Support for standard
> {code:java}
> GROUP BY { group_expression |
> { ROLLUP | CUBE | GROUPING SETS }
> (grouping_set [ , ...]) } [ , ... ] {code}
>  syntax was added to Spark several releases ago in addition to the previously supported non-standard syntax 
> {code:java}
> GROUP BY group_expression [ , group_expression [ , ... ] ] [ WITH { ROLLUP | CUBE } ] {code}
> See: [https://spark.apache.org/docs/latest/sql-ref-syntax-qry-select-groupby.html]
> We need to update *SparkSqlDialect* implementation to reflect these changes in supported SQL syntax.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)