You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Eli Collins (JIRA)" <ji...@apache.org> on 2011/08/18 02:49:27 UTC
[jira] [Created] (HADOOP-7552) FileUtil#fullyDelete doesn't throw
IOE but lists it in the throws clause
FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause
------------------------------------------------------------------------
Key: HADOOP-7552
URL: https://issues.apache.org/jira/browse/HADOOP-7552
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Reporter: Eli Collins
Assignee: Eli Collins
Priority: Minor
Fix For: 0.23.0
FileUtil#fullyDelete doesn't throw IOException so it shouldn't have IOException in its throws clause. Having it listed makes it easy to think you'll get an IOException eg trying to delete a non-existant file or on an IO error accessing the local file, but you don't.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7552) FileUtil#fullyDelete doesn't throw
IOE but lists it in the throws clause
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096934#comment-13096934 ]
Aaron T. Myers commented on HADOOP-7552:
----------------------------------------
Looks like this change inadvertently broke MR trunk: https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/833/
> FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause
> ------------------------------------------------------------------------
>
> Key: HADOOP-7552
> URL: https://issues.apache.org/jira/browse/HADOOP-7552
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hadoop-7552-1.patch, hadoop-7552-2.patch, hadoop-7552-3.patch, hadoop-7552-3.patch, hadoop-7552-3.patch
>
>
> FileUtil#fullyDelete doesn't throw IOException so it shouldn't have IOException in its throws clause. Having it listed makes it easy to think you'll get an IOException eg trying to delete a non-existant file or on an IO error accessing the local file, but you don't.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7552) FileUtil#fullyDelete doesn't throw
IOE but lists it in the throws clause
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-7552:
--------------------------------
Attachment: hadoop-7552-2.patch
Thanks Uma. Patch with this nit and similar addressed.
> FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause
> ------------------------------------------------------------------------
>
> Key: HADOOP-7552
> URL: https://issues.apache.org/jira/browse/HADOOP-7552
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hadoop-7552-1.patch, hadoop-7552-2.patch
>
>
> FileUtil#fullyDelete doesn't throw IOException so it shouldn't have IOException in its throws clause. Having it listed makes it easy to think you'll get an IOException eg trying to delete a non-existant file or on an IO error accessing the local file, but you don't.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7552) FileUtil#fullyDelete doesn't throw
IOE but lists it in the throws clause
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-7552:
--------------------------------
Attachment: hadoop-7552-1.patch
Patch attached.
Updates the method signatures. Also:
* Adds a test to TestLocalFileSystem
* Converts TestLocalFileSystem
* Shares read/write file methods across local FileSystem tests
Will add in the MR side once MR2 has merged.
> FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause
> ------------------------------------------------------------------------
>
> Key: HADOOP-7552
> URL: https://issues.apache.org/jira/browse/HADOOP-7552
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hadoop-7552-1.patch
>
>
> FileUtil#fullyDelete doesn't throw IOException so it shouldn't have IOException in its throws clause. Having it listed makes it easy to think you'll get an IOException eg trying to delete a non-existant file or on an IO error accessing the local file, but you don't.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7552) FileUtil#fullyDelete doesn't throw
IOE but lists it in the throws clause
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095155#comment-13095155 ]
Hadoop QA commented on HADOOP-7552:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12492569/hadoop-7552-3.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 46 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/117//console
This message is automatically generated.
> FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause
> ------------------------------------------------------------------------
>
> Key: HADOOP-7552
> URL: https://issues.apache.org/jira/browse/HADOOP-7552
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hadoop-7552-1.patch, hadoop-7552-2.patch, hadoop-7552-3.patch
>
>
> FileUtil#fullyDelete doesn't throw IOException so it shouldn't have IOException in its throws clause. Having it listed makes it easy to think you'll get an IOException eg trying to delete a non-existant file or on an IO error accessing the local file, but you don't.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7552) FileUtil#fullyDelete doesn't throw
IOE but lists it in the throws clause
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095757#comment-13095757 ]
Aaron T. Myers commented on HADOOP-7552:
----------------------------------------
The test-patch failures are almost certainly this: HADOOP-7598
> FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause
> ------------------------------------------------------------------------
>
> Key: HADOOP-7552
> URL: https://issues.apache.org/jira/browse/HADOOP-7552
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hadoop-7552-1.patch, hadoop-7552-2.patch, hadoop-7552-3.patch, hadoop-7552-3.patch, hadoop-7552-3.patch
>
>
> FileUtil#fullyDelete doesn't throw IOException so it shouldn't have IOException in its throws clause. Having it listed makes it easy to think you'll get an IOException eg trying to delete a non-existant file or on an IO error accessing the local file, but you don't.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7552) FileUtil#fullyDelete doesn't throw
IOE but lists it in the throws clause
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095957#comment-13095957 ]
Hudson commented on HADOOP-7552:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #804 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/804/])
HADOOP-7552. FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause. Contributed by Eli Collins
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1164339
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/RawLocalFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/RunJar.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemTestHelper.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestDU.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHardLink.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/nativeio/TestNativeIO.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestRunJar.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestListFilesInFileContext.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestJvmManager.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestLinuxTaskController.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestTaskOutputSize.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestUserLogCleanup.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/util/TestMRAsyncDiskService.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/util/TestProcfsBasedProcessTree.java
> FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause
> ------------------------------------------------------------------------
>
> Key: HADOOP-7552
> URL: https://issues.apache.org/jira/browse/HADOOP-7552
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hadoop-7552-1.patch, hadoop-7552-2.patch, hadoop-7552-3.patch, hadoop-7552-3.patch, hadoop-7552-3.patch
>
>
> FileUtil#fullyDelete doesn't throw IOException so it shouldn't have IOException in its throws clause. Having it listed makes it easy to think you'll get an IOException eg trying to delete a non-existant file or on an IO error accessing the local file, but you don't.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7552) FileUtil#fullyDelete doesn't throw
IOE but lists it in the throws clause
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095813#comment-13095813 ]
Hudson commented on HADOOP-7552:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #833 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/833/])
HADOOP-7552. FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause. Contributed by Eli Collins
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1164339
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/RawLocalFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/RunJar.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemTestHelper.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestDU.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHardLink.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/nativeio/TestNativeIO.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestRunJar.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestListFilesInFileContext.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestJvmManager.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestLinuxTaskController.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestTaskOutputSize.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestUserLogCleanup.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/util/TestMRAsyncDiskService.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/util/TestProcfsBasedProcessTree.java
> FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause
> ------------------------------------------------------------------------
>
> Key: HADOOP-7552
> URL: https://issues.apache.org/jira/browse/HADOOP-7552
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hadoop-7552-1.patch, hadoop-7552-2.patch, hadoop-7552-3.patch, hadoop-7552-3.patch, hadoop-7552-3.patch
>
>
> FileUtil#fullyDelete doesn't throw IOException so it shouldn't have IOException in its throws clause. Having it listed makes it easy to think you'll get an IOException eg trying to delete a non-existant file or on an IO error accessing the local file, but you don't.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7552) FileUtil#fullyDelete doesn't throw
IOE but lists it in the throws clause
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-7552:
--------------------------------
Attachment: hadoop-7552-3.patch
> FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause
> ------------------------------------------------------------------------
>
> Key: HADOOP-7552
> URL: https://issues.apache.org/jira/browse/HADOOP-7552
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hadoop-7552-1.patch, hadoop-7552-2.patch, hadoop-7552-3.patch, hadoop-7552-3.patch, hadoop-7552-3.patch
>
>
> FileUtil#fullyDelete doesn't throw IOException so it shouldn't have IOException in its throws clause. Having it listed makes it easy to think you'll get an IOException eg trying to delete a non-existant file or on an IO error accessing the local file, but you don't.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7552) FileUtil#fullyDelete doesn't throw
IOE but lists it in the throws clause
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095650#comment-13095650 ]
Aaron T. Myers commented on HADOOP-7552:
----------------------------------------
Latest patch looks pretty good to me. One question - why add the static import in {{TestListFilesInFileContext}}? It seems to be unused.
+1 pending an answer to that question.
> FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause
> ------------------------------------------------------------------------
>
> Key: HADOOP-7552
> URL: https://issues.apache.org/jira/browse/HADOOP-7552
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hadoop-7552-1.patch, hadoop-7552-2.patch, hadoop-7552-3.patch, hadoop-7552-3.patch, hadoop-7552-3.patch
>
>
> FileUtil#fullyDelete doesn't throw IOException so it shouldn't have IOException in its throws clause. Having it listed makes it easy to think you'll get an IOException eg trying to delete a non-existant file or on an IO error accessing the local file, but you don't.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7552) FileUtil#fullyDelete doesn't throw
IOE but lists it in the throws clause
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095741#comment-13095741 ]
Eli Collins commented on HADOOP-7552:
-------------------------------------
Thanks atm, removed this import. Not sure what's going on with test-patch, previous test-patch results were same patch.
> FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause
> ------------------------------------------------------------------------
>
> Key: HADOOP-7552
> URL: https://issues.apache.org/jira/browse/HADOOP-7552
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hadoop-7552-1.patch, hadoop-7552-2.patch, hadoop-7552-3.patch, hadoop-7552-3.patch, hadoop-7552-3.patch
>
>
> FileUtil#fullyDelete doesn't throw IOException so it shouldn't have IOException in its throws clause. Having it listed makes it easy to think you'll get an IOException eg trying to delete a non-existant file or on an IO error accessing the local file, but you don't.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7552) FileUtil#fullyDelete doesn't throw
IOE but lists it in the throws clause
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098444#comment-13098444 ]
Eli Collins commented on HADOOP-7552:
-------------------------------------
I think the issue is that MR trunk is using an old common jar.
> FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause
> ------------------------------------------------------------------------
>
> Key: HADOOP-7552
> URL: https://issues.apache.org/jira/browse/HADOOP-7552
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hadoop-7552-1.patch, hadoop-7552-2.patch, hadoop-7552-3.patch, hadoop-7552-3.patch, hadoop-7552-3.patch
>
>
> FileUtil#fullyDelete doesn't throw IOException so it shouldn't have IOException in its throws clause. Having it listed makes it easy to think you'll get an IOException eg trying to delete a non-existant file or on an IO error accessing the local file, but you don't.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7552) FileUtil#fullyDelete doesn't throw
IOE but lists it in the throws clause
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087553#comment-13087553 ]
Uma Maheswara Rao G commented on HADOOP-7552:
---------------------------------------------
+1 Patch looks good to me.
> FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause
> ------------------------------------------------------------------------
>
> Key: HADOOP-7552
> URL: https://issues.apache.org/jira/browse/HADOOP-7552
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hadoop-7552-1.patch, hadoop-7552-2.patch
>
>
> FileUtil#fullyDelete doesn't throw IOException so it shouldn't have IOException in its throws clause. Having it listed makes it easy to think you'll get an IOException eg trying to delete a non-existant file or on an IO error accessing the local file, but you don't.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7552) FileUtil#fullyDelete doesn't throw
IOE but lists it in the throws clause
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095945#comment-13095945 ]
Hudson commented on HADOOP-7552:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #780 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/780/])
HADOOP-7552. FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause. Contributed by Eli Collins
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1164339
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/RawLocalFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/RunJar.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemTestHelper.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestDU.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHardLink.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/nativeio/TestNativeIO.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestRunJar.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestListFilesInFileContext.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestJvmManager.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestLinuxTaskController.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestTaskOutputSize.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestUserLogCleanup.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/util/TestMRAsyncDiskService.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/util/TestProcfsBasedProcessTree.java
> FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause
> ------------------------------------------------------------------------
>
> Key: HADOOP-7552
> URL: https://issues.apache.org/jira/browse/HADOOP-7552
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hadoop-7552-1.patch, hadoop-7552-2.patch, hadoop-7552-3.patch, hadoop-7552-3.patch, hadoop-7552-3.patch
>
>
> FileUtil#fullyDelete doesn't throw IOException so it shouldn't have IOException in its throws clause. Having it listed makes it easy to think you'll get an IOException eg trying to delete a non-existant file or on an IO error accessing the local file, but you don't.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7552) FileUtil#fullyDelete doesn't throw
IOE but lists it in the throws clause
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-7552:
--------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I've committed this.
> FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause
> ------------------------------------------------------------------------
>
> Key: HADOOP-7552
> URL: https://issues.apache.org/jira/browse/HADOOP-7552
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hadoop-7552-1.patch, hadoop-7552-2.patch, hadoop-7552-3.patch, hadoop-7552-3.patch, hadoop-7552-3.patch
>
>
> FileUtil#fullyDelete doesn't throw IOException so it shouldn't have IOException in its throws clause. Having it listed makes it easy to think you'll get an IOException eg trying to delete a non-existant file or on an IO error accessing the local file, but you don't.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7552) FileUtil#fullyDelete doesn't throw
IOE but lists it in the throws clause
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095806#comment-13095806 ]
Hudson commented on HADOOP-7552:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #900 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/900/])
HADOOP-7552. FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause. Contributed by Eli Collins
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1164339
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/RawLocalFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/RunJar.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemTestHelper.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestDU.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHardLink.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/nativeio/TestNativeIO.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestRunJar.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestListFilesInFileContext.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestJvmManager.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestLinuxTaskController.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestTaskOutputSize.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapred/TestUserLogCleanup.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/util/TestMRAsyncDiskService.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/mapreduce/util/TestProcfsBasedProcessTree.java
> FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause
> ------------------------------------------------------------------------
>
> Key: HADOOP-7552
> URL: https://issues.apache.org/jira/browse/HADOOP-7552
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hadoop-7552-1.patch, hadoop-7552-2.patch, hadoop-7552-3.patch, hadoop-7552-3.patch, hadoop-7552-3.patch
>
>
> FileUtil#fullyDelete doesn't throw IOException so it shouldn't have IOException in its throws clause. Having it listed makes it easy to think you'll get an IOException eg trying to delete a non-existant file or on an IO error accessing the local file, but you don't.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7552) FileUtil#fullyDelete doesn't throw
IOE but lists it in the throws clause
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087397#comment-13087397 ]
Hadoop QA commented on HADOOP-7552:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12490724/hadoop-7552-1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 16 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/51//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/51//artifact/trunk/target/newPatchFindbugsWarningshadoop-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/51//artifact/trunk/target/newPatchFindbugsWarningshadoop-annotations.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/51//console
This message is automatically generated.
> FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause
> ------------------------------------------------------------------------
>
> Key: HADOOP-7552
> URL: https://issues.apache.org/jira/browse/HADOOP-7552
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hadoop-7552-1.patch
>
>
> FileUtil#fullyDelete doesn't throw IOException so it shouldn't have IOException in its throws clause. Having it listed makes it easy to think you'll get an IOException eg trying to delete a non-existant file or on an IO error accessing the local file, but you don't.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7552) FileUtil#fullyDelete doesn't throw
IOE but lists it in the throws clause
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-7552:
--------------------------------
Attachment: hadoop-7552-3.patch
Rebased on trunk.
> FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause
> ------------------------------------------------------------------------
>
> Key: HADOOP-7552
> URL: https://issues.apache.org/jira/browse/HADOOP-7552
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hadoop-7552-1.patch, hadoop-7552-2.patch, hadoop-7552-3.patch
>
>
> FileUtil#fullyDelete doesn't throw IOException so it shouldn't have IOException in its throws clause. Having it listed makes it easy to think you'll get an IOException eg trying to delete a non-existant file or on an IO error accessing the local file, but you don't.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7552) FileUtil#fullyDelete doesn't throw
IOE but lists it in the throws clause
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095448#comment-13095448 ]
Hadoop QA commented on HADOOP-7552:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12492630/hadoop-7552-3.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 46 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/120//console
This message is automatically generated.
> FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause
> ------------------------------------------------------------------------
>
> Key: HADOOP-7552
> URL: https://issues.apache.org/jira/browse/HADOOP-7552
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hadoop-7552-1.patch, hadoop-7552-2.patch, hadoop-7552-3.patch, hadoop-7552-3.patch
>
>
> FileUtil#fullyDelete doesn't throw IOException so it shouldn't have IOException in its throws clause. Having it listed makes it easy to think you'll get an IOException eg trying to delete a non-existant file or on an IO error accessing the local file, but you don't.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7552) FileUtil#fullyDelete doesn't throw
IOE but lists it in the throws clause
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087508#comment-13087508 ]
Uma Maheswara Rao G commented on HADOOP-7552:
---------------------------------------------
Hi Eli,
I have verified this patch. Looks no issue.
I have one very small nit.
I think, in TestNativeIO also we can remove throws class.
{code}
@Before
public void setupTestDir() throws IOException {
FileUtil.fullyDelete(TEST_DIR);
TEST_DIR.mkdirs();
}
{code}
There are some instances in HDFS also like this, but we can handle them separately may be. Since this is testcode, you can decide based on priority.
Other than this patch looks good!
+1 from my side.
> FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause
> ------------------------------------------------------------------------
>
> Key: HADOOP-7552
> URL: https://issues.apache.org/jira/browse/HADOOP-7552
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hadoop-7552-1.patch
>
>
> FileUtil#fullyDelete doesn't throw IOException so it shouldn't have IOException in its throws clause. Having it listed makes it easy to think you'll get an IOException eg trying to delete a non-existant file or on an IO error accessing the local file, but you don't.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7552) FileUtil#fullyDelete doesn't throw
IOE but lists it in the throws clause
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-7552:
--------------------------------
Status: Patch Available (was: Open)
Looks like none of the uses in MR are affected, so the patch should be good to go.
> FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause
> ------------------------------------------------------------------------
>
> Key: HADOOP-7552
> URL: https://issues.apache.org/jira/browse/HADOOP-7552
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hadoop-7552-1.patch
>
>
> FileUtil#fullyDelete doesn't throw IOException so it shouldn't have IOException in its throws clause. Having it listed makes it easy to think you'll get an IOException eg trying to delete a non-existant file or on an IO error accessing the local file, but you don't.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7552) FileUtil#fullyDelete doesn't throw
IOE but lists it in the throws clause
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-7552:
--------------------------------
Attachment: hadoop-7552-3.patch
Hm, applies for me. Trying again.
> FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause
> ------------------------------------------------------------------------
>
> Key: HADOOP-7552
> URL: https://issues.apache.org/jira/browse/HADOOP-7552
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hadoop-7552-1.patch, hadoop-7552-2.patch, hadoop-7552-3.patch, hadoop-7552-3.patch
>
>
> FileUtil#fullyDelete doesn't throw IOException so it shouldn't have IOException in its throws clause. Having it listed makes it easy to think you'll get an IOException eg trying to delete a non-existant file or on an IO error accessing the local file, but you don't.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7552) FileUtil#fullyDelete doesn't throw
IOE but lists it in the throws clause
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087537#comment-13087537 ]
Hadoop QA commented on HADOOP-7552:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12490917/hadoop-7552-2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 49 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/54//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/54//artifact/trunk/target/newPatchFindbugsWarningshadoop-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/54//artifact/trunk/target/newPatchFindbugsWarningshadoop-annotations.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/54//console
This message is automatically generated.
> FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause
> ------------------------------------------------------------------------
>
> Key: HADOOP-7552
> URL: https://issues.apache.org/jira/browse/HADOOP-7552
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: hadoop-7552-1.patch, hadoop-7552-2.patch
>
>
> FileUtil#fullyDelete doesn't throw IOException so it shouldn't have IOException in its throws clause. Having it listed makes it easy to think you'll get an IOException eg trying to delete a non-existant file or on an IO error accessing the local file, but you don't.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira