You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "123123213weqw (via GitHub)" <gi...@apache.org> on 2026/10/09 06:30:14 UTC

[PR] fix(client): sort aggregated connection rows [rocketmq-dashboard]

123123213weqw opened a new pull request, #5773:
URL: https://github.com/apache/rocketmq-dashboard/pull/5773

   ## What
   
   `RocketMQClientProvider.findConnections` aggregates producer and consumer
   connection rows by walking the broker topology table (`brokerAddrTable`, a
   deserialized `HashMap`) and, per broker, each producer/consumer table (also
   hash maps). The output list therefore inherits hash-based iteration order and
   reshuffles between two snapshots of the same cluster, which makes the client
   list flicker and defeats any eyeball diffing of connections.
   
   ## Fix
   
   Sort the aggregated rows by a stable key — type, group/topic, clientId,
   address — before returning, so the client list is deterministic across
   snapshots.
   
   ## Test
   
   `connectionScanShouldReturnStableOrderAcrossTopologyChanges` feeds a topology
   whose broker table iterates in reverse-address order with one producer group
   per broker and asserts the rows come out group-ordered. Red on the current
   code (rows follow the table's iteration order), green after the sort.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(client): sort aggregated connection rows [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #5773:
URL: https://github.com/apache/rocketmq-dashboard/pull/5773


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(client): sort aggregated connection rows [rocketmq-dashboard]

Posted by "123123213weqw (via GitHub)" <gi...@apache.org>.
123123213weqw commented on PR #5773:
URL: https://github.com/apache/rocketmq-dashboard/pull/5773#issuecomment-6123345954

   @lizhimins Refreshed this branch onto the current `rocketmq-studio` — no conflicts, and this PR's own tests pass: `RocketMQClientProviderTest` green.
   
   Two CI notes that are not this PR's doing:
   
   - **Backend Build** is red for every open PR right now: the `binary-license-gate` (`server/pom.xml` → `scripts/legal.py`) fails on the current `rocketmq-studio` HEAD as well — the spring-ai/swagger-ui/tencentcloud/webjars/zstd-jni jars carry no embedded LICENSE/COPYING text for the gate to collect, and it has been red on base since it landed (no completed green CI run on the branch since it was introduced). Not something this PR can fix from its own branch.
   - **Backend Tests** was red here on the shared flake `ResourceOwnershipGuardTest.migrationConcurrentStartupIsIdempotentTest` (H2 `ConcurrentModificationException` under concurrent startup); that test passes standalone on base and is untouched by this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org