You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/08/21 15:34:11 UTC

[jira] [Commented] (THRIFT-2672) Provide origin of call via TTransport

    [ https://issues.apache.org/jira/browse/THRIFT-2672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14105365#comment-14105365 ] 

ASF GitHub Bot commented on THRIFT-2672:
----------------------------------------

GitHub user pascal-bach opened a pull request:

    https://github.com/apache/thrift/pull/199

    Add getOrigin() function to TTransport

    getOrigin returns the origin of a request, the value depends on the transport used
    
    See: THRIFT-2672

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/siemens/thrift THRIFT-2672

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/199.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #199
    
----
commit 9be413fca40d75559c2776618c904a5e140d3418
Author: Pascal Bach <pa...@siemens.com>
Date:   2014-08-21T11:37:11Z

    Add getOrigin() function to TTransport
    
    getOrigin returns the origin of a request, the value depends on the transport used

----


> Provide origin of call via TTransport
> -------------------------------------
>
>                 Key: THRIFT-2672
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2672
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>    Affects Versions: 1.0
>            Reporter: Pascal Bach
>
> In some situations it is helpful to be able to get the origin of a thrift call.
> Some transport like TSocket provide methods for this ({{getPeerAddress}}).
> However to access this a cast is required and the transport type hase to be known.
> This patch adds a new method called {{getOrigin}} to TTransport. The function returns a string representing the origin of the call.
> The implementation of {{getOrigin}} is transport specific.
> E.g. the TSocket transport returns the IP and port of the remote socket.
> Transports that don't know about the origin just return _Unknown_.



--
This message was sent by Atlassian JIRA
(v6.2#6252)