You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sebastian Toader <st...@hortonworks.com> on 2015/12/10 19:03:11 UTC
Review Request 41213: Storm 'nimbus.seeds' property not handled
correctly in
Blueprint processor resulting Storm not being able to start.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41213/
-----------------------------------------------------------
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Bugs: AMBARI-14325
https://issues.apache.org/jira/browse/AMBARI-14325
Repository: ambari
Description
-------
MultipleHostTopologyUpdater handled only yaml type of config properties where the original value was enclosed by ['']. This has been extended to handle also property value enclosed only by [] (no simple quote)
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 457b78b
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 033fe10
Diff: https://reviews.apache.org/r/41213/diff/
Testing
-------
Manual testing for both single and multi node scenarios.
Unit tests in progress.
Thanks,
Sebastian Toader
Re: Review Request 41213: Storm 'nimbus.seeds' property not handled
correctly in Blueprint processor resulting Storm not being able to start.
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41213/#review109846
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On Dec. 10, 2015, 6:48 p.m., Sebastian Toader wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41213/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 6:48 p.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-14325
> https://issues.apache.org/jira/browse/AMBARI-14325
>
>
> Repository: ambari
>
>
> Description
> -------
>
> MultipleHostTopologyUpdater handled only yaml type of config properties where the original value was enclosed by ['']. This has been extended to handle also property value enclosed only by [] (no simple quote)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 457b78b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 033fe10
>
> Diff: https://reviews.apache.org/r/41213/diff/
>
>
> Testing
> -------
>
> Manual testing for both single and multi node scenarios.
>
>
> Unit tests in progress.
>
>
> Thanks,
>
> Sebastian Toader
>
>
Re: Review Request 41213: Storm 'nimbus.seeds' property not handled
correctly in Blueprint processor resulting Storm not being able to start.
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41213/
-----------------------------------------------------------
(Updated Dec. 10, 2015, 10:12 p.m.)
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Bugs: AMBARI-14325
https://issues.apache.org/jira/browse/AMBARI-14325
Repository: ambari
Description
-------
MultipleHostTopologyUpdater handled only yaml type of config properties where the original value was enclosed by ['']. This has been extended to handle also property value enclosed only by [] (no simple quote)
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 457b78b
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 033fe10
Diff: https://reviews.apache.org/r/41213/diff/
Testing (updated)
-------
Manual testing for both single and multi node scenarios.
Unit tests results:
Tests run: 3602, Failures: 0, Errors: 0, Skipped: 28
Thanks,
Sebastian Toader
Re: Review Request 41213: Storm 'nimbus.seeds' property not handled
correctly in Blueprint processor resulting Storm not being able to start.
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41213/#review109827
-----------------------------------------------------------
Ship it!
Ship It!
- Oliver Szabo
On Dec. 10, 2015, 6:48 p.m., Sebastian Toader wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41213/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 6:48 p.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-14325
> https://issues.apache.org/jira/browse/AMBARI-14325
>
>
> Repository: ambari
>
>
> Description
> -------
>
> MultipleHostTopologyUpdater handled only yaml type of config properties where the original value was enclosed by ['']. This has been extended to handle also property value enclosed only by [] (no simple quote)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 457b78b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 033fe10
>
> Diff: https://reviews.apache.org/r/41213/diff/
>
>
> Testing
> -------
>
> Manual testing for both single and multi node scenarios.
>
>
> Unit tests in progress.
>
>
> Thanks,
>
> Sebastian Toader
>
>
Re: Review Request 41213: Storm 'nimbus.seeds' property not handled
correctly in Blueprint processor resulting Storm not being able to start.
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41213/
-----------------------------------------------------------
(Updated Dec. 10, 2015, 7:48 p.m.)
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Changes
-------
Fix suffix handling.
Bugs: AMBARI-14325
https://issues.apache.org/jira/browse/AMBARI-14325
Repository: ambari
Description
-------
MultipleHostTopologyUpdater handled only yaml type of config properties where the original value was enclosed by ['']. This has been extended to handle also property value enclosed only by [] (no simple quote)
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 457b78b
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 033fe10
Diff: https://reviews.apache.org/r/41213/diff/
Testing
-------
Manual testing for both single and multi node scenarios.
Unit tests in progress.
Thanks,
Sebastian Toader