You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airavata.apache.org by sh...@apache.org on 2015/06/01 20:37:33 UTC

airavata git commit: added meaning full failed message when absence of jobId in both submit and validate steps

Repository: airavata
Updated Branches:
  refs/heads/airavata-0.15-release-branch 4a0617802 -> 05fb8d32f


added meaning full failed message when absence of jobId in both submit and validate steps


Project: http://git-wip-us.apache.org/repos/asf/airavata/repo
Commit: http://git-wip-us.apache.org/repos/asf/airavata/commit/05fb8d32
Tree: http://git-wip-us.apache.org/repos/asf/airavata/tree/05fb8d32
Diff: http://git-wip-us.apache.org/repos/asf/airavata/diff/05fb8d32

Branch: refs/heads/airavata-0.15-release-branch
Commit: 05fb8d32f175a1cd2fcc4009f4c327262b369ddf
Parents: 4a06178
Author: Shameera Rathanyaka <sh...@gmail.com>
Authored: Mon Jun 1 14:37:26 2015 -0400
Committer: Shameera Rathanyaka <sh...@gmail.com>
Committed: Mon Jun 1 14:37:26 2015 -0400

----------------------------------------------------------------------
 .../apache/airavata/gfac/ssh/provider/impl/SSHProvider.java    | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/airavata/blob/05fb8d32/modules/gfac/gfac-ssh/src/main/java/org/apache/airavata/gfac/ssh/provider/impl/SSHProvider.java
----------------------------------------------------------------------
diff --git a/modules/gfac/gfac-ssh/src/main/java/org/apache/airavata/gfac/ssh/provider/impl/SSHProvider.java b/modules/gfac/gfac-ssh/src/main/java/org/apache/airavata/gfac/ssh/provider/impl/SSHProvider.java
index f967dbf..ec8829a 100644
--- a/modules/gfac/gfac-ssh/src/main/java/org/apache/airavata/gfac/ssh/provider/impl/SSHProvider.java
+++ b/modules/gfac/gfac-ssh/src/main/java/org/apache/airavata/gfac/ssh/provider/impl/SSHProvider.java
@@ -63,6 +63,7 @@ import org.apache.airavata.model.workspace.experiment.ErrorCategory;
 import org.apache.airavata.model.workspace.experiment.ExperimentState;
 import org.apache.airavata.model.workspace.experiment.JobDetails;
 import org.apache.airavata.model.workspace.experiment.JobState;
+import org.apache.airavata.model.workspace.experiment.TaskState;
 import org.apache.xmlbeans.XmlException;
 import org.apache.zookeeper.KeeperException;
 import org.slf4j.Logger;
@@ -188,8 +189,9 @@ public class SSHProvider extends AbstractProvider {
                     }
 
                     if (jobID == null || jobID.isEmpty()) {
-                        log.error("Couldn't find remote jobId for JobName:" + jobDetails.getJobName() + ", ExperimentId:" + jobExecutionContext.getExperimentID());
-                        GFacUtils.updateExperimentStatus(jobExecutionContext.getExperimentID(), ExperimentState.FAILED);
+                        log.error("expId:" + jobExecutionContext.getExperimentID() + " Couldn't find remote jobId for JobName:"
+                                + jobDetails.getJobName() + ", both submit and verify steps doesn't return a valid JobId. Hence changing task state to Failed");
+                        GFacUtils.publishTaskStatus(jobExecutionContext, monitorPublisher, TaskState.FAILED);
                         return;
                     }
                     data.append("jobDesc=").append(jobDescriptor.toXML());