Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite

[Noorul Islam K M <no...@collab.net>]

Gavin Baumanis <ga...@thespidernet.com> writes:

> Hi Noorul,
>
> Just a quick message to see if you're still working on this patch or not?
> My threads stop at the comments below from Andrew?
>

Someone has to review this and if everything is fine commit it. Julian
did review this earlier and I submitted updated patch. After that this
thread has got no updates.

Thanks and Regards
Noorul

>
>
> On 01/03/2011, at 12:25 AM, Bolstridge, Andrew wrote:
>
>> 
>>> -----Original Message-----
>>> From: Julian Foad [mailto:julian.foad@wandisco.com]
>>> Sent: 25 February 2011 15:33
>>> To: Noorul Islam K M
>>> Cc: Subversion
>>> Subject: Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite
>>> 
>>> On Sat, 2011-02-19, Noorul Islam K M wrote:
>>>> I think it is this way
>>>> 
>>>> If specified target ('/tmp/iota' in the example above) is a ...
>>>>  nothing -> fine
>>>>  file    -> if 'force' then overwrite else error
>>>>  symlink -> if 'force' then overwrite else error
>>>>  special -> if 'force' then overwrite else error
>>>>  dir     -> if sub-target ('/tmp/iota/iota') is a ...
>>>>    nothing -> fine
>>>>    file    -> if 'force' then overwrite else error
>>>>    symlink -> if 'force' then overwrite else error
>>>>    special -> if 'force' then overwrite else error
>>>>    dir     -> error cannot force
>>> 
>>> (That's all when the source is a file; a dir is handled differently.)
>>> 
>>> OK, that looks good.  I agree that that would be a good behaviour to
>>> implement.
>>> 
>> My 2p:
>> 
>> Why would we want dirs to be handled differently? Surely, we want the behaviour to be "as expected" as possible, and if file export behaves differently to directory export... that's not so good. 
>> 
>> Also, does this work as intended when using externals? I recall trying to export directories using externals to the same location on the filesystem and finding that each external wiped the target before copying the files (imagine you have several C modules and want to export all the headers from each of them to a single include directory, as an example of what I was trying to achieve).
>> 
>> 

Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite

[Noorul Islam K M <no...@collab.net>]

Stefan Sperling <st...@elego.de> writes:

> On Fri, May 20, 2011 at 01:04:18PM +0200, Stefan Sperling wrote:
>
>> On Fri, May 20, 2011 at 03:25:50PM +0530, Noorul Islam K M wrote:
>> > Pinging again. 
>> 
>> Looking into this...
>
> Noorul,
>
> unfortunately your patch does not apply cleanly to trunk anymore.
> Can you update it? Thanks!

Attached is the updated patch. 

Log

[[[ 

Fix for issue #3799. Make svn export display error, when exporting file,
tries to overwrite target.

* subversion/libsvn_client/export.c
  (copy_versioned_files, svn_client_export5): Return
    SVN_ERR_FS_ALREADY_EXISTS if export tries to overwrite existing
    file, child directory.

* subversion/tests/cmdline/export_tests.py
  (export_file_overwrite_fails): Extend test for URL source. Remove
    XFail marker.
  (export_file_overwrite_with_force): New test
  (test_list): Add reference to new test

* subversion/tests/cmdline/externals_tests.py
  (export_wc_with_externals): Fix failing test by passing --force.

Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
]]]

Thanks and Regards
Noorul

Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite

[Stefan Sperling <st...@elego.de>]

On Fri, May 20, 2011 at 01:04:18PM +0200, Stefan Sperling wrote:
> On Fri, May 20, 2011 at 03:25:50PM +0530, Noorul Islam K M wrote:
> > Pinging again. 
> 
> Looking into this...

Noorul,

unfortunately your patch does not apply cleanly to trunk anymore.
Can you update it? Thanks!

Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite

[Stefan Sperling <st...@elego.de>]

On Fri, May 20, 2011 at 03:25:50PM +0530, Noorul Islam K M wrote:
> Pinging again. 

Looking into this...

Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite

[Noorul Islam K M <no...@collab.net>]

Noorul Islam K M <no...@collab.net> writes:

> Noorul Islam K M <no...@collab.net> writes:
>
>> Gavin Baumanis <ga...@thespidernet.com> writes:
>>
>>> Hi Noorul,
>>>
>>> Just a quick message to see if you're still working on this patch or not?
>>> My threads stop at the comments below from Andrew?
>>>
>>
>> Someone has to review this and if everything is fine commit it. Julian
>> did review this earlier and I submitted updated patch. After that this
>> thread has got no updates.
>>
>
> Pinging again. This has been pending for long time now.
>

Pinging again. 

Thanks and Regards
Noorul

Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite

[Noorul Islam K M <no...@collab.net>]

Noorul Islam K M <no...@collab.net> writes:

> Gavin Baumanis <ga...@thespidernet.com> writes:
>
>> Hi Noorul,
>>
>> Just a quick message to see if you're still working on this patch or not?
>> My threads stop at the comments below from Andrew?
>>
>
> Someone has to review this and if everything is fine commit it. Julian
> did review this earlier and I submitted updated patch. After that this
> thread has got no updates.
>

Pinging again. This has been pending for long time now.

Thanks and Regards
Noorul