You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/05/07 07:42:20 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #28437: [SPARK-30385][WEBUI] WebUI occasionally throw IOException on stop()

cloud-fan commented on a change in pull request #28437:
URL: https://github.com/apache/spark/pull/28437#discussion_r421302619



##########
File path: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala
##########
@@ -496,10 +496,16 @@ private[spark] case class ServerInfo(
   }
 
   def stop(): Unit = {
+    val threadPool = server.getThreadPool

Review comment:
       then there will be a chance that we trigger the bug before setting the idle timeout?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org