You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Konstantin Shvachko (JIRA)" <ji...@apache.org> on 2007/07/18 04:59:04 UTC

[jira] Created: (HADOOP-1626) DFSAdmin. Help messages are missing for -finalizeUpgrade and -metasave.

DFSAdmin. Help messages are missing for -finalizeUpgrade and -metasave.
-----------------------------------------------------------------------

                 Key: HADOOP-1626
                 URL: https://issues.apache.org/jira/browse/HADOOP-1626
             Project: Hadoop
          Issue Type: Improvement
          Components: dfs
    Affects Versions: 0.13.0
            Reporter: Konstantin Shvachko
            Priority: Minor
             Fix For: 0.15.0


DFSAdmin.printHelp() does not print help for the two commands above.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-1626) DFSAdmin. Help messages are missing for -finalizeUpgrade and -metasave.

Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nigel Daley updated HADOOP-1626:
--------------------------------

    Assignee: lohit vijayarenu

> DFSAdmin. Help messages are missing for -finalizeUpgrade and -metasave.
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-1626
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1626
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.13.0
>            Reporter: Konstantin Shvachko
>            Assignee: lohit vijayarenu
>            Priority: Blocker
>             Fix For: 0.15.0
>
>         Attachments: HADOOP-1626.2.patch, HADOOP-1626.patch
>
>
> DFSAdmin.printHelp() does not print help for the two commands above.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-1626) DFSAdmin. Help messages are missing for -finalizeUpgrade and -metasave.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532073 ] 

Hudson commented on HADOOP-1626:
--------------------------------

Integrated in Hadoop-Nightly #259 (See [http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/259/])

> DFSAdmin. Help messages are missing for -finalizeUpgrade and -metasave.
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-1626
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1626
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.13.0
>            Reporter: Konstantin Shvachko
>            Assignee: lohit vijayarenu
>            Priority: Blocker
>             Fix For: 0.15.0
>
>         Attachments: HADOOP-1626.2.patch, HADOOP-1626.patch
>
>
> DFSAdmin.printHelp() does not print help for the two commands above.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-1626) DFSAdmin. Help messages are missing for -finalizeUpgrade and -metasave.

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531966 ] 

Hadoop QA commented on HADOOP-1626:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12366961/HADOOP-1626.2.patch
against trunk revision r581427.

    @author +1.  The patch does not contain any @author tags.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new compiler warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/870/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/870/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/870/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/870/console

This message is automatically generated.

> DFSAdmin. Help messages are missing for -finalizeUpgrade and -metasave.
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-1626
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1626
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.13.0
>            Reporter: Konstantin Shvachko
>            Assignee: lohit vijayarenu
>            Priority: Blocker
>             Fix For: 0.15.0
>
>         Attachments: HADOOP-1626.2.patch, HADOOP-1626.patch
>
>
> DFSAdmin.printHelp() does not print help for the two commands above.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-1626) DFSAdmin. Help messages are missing for -finalizeUpgrade and -metasave.

Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nigel Daley updated HADOOP-1626:
--------------------------------

    Status: Patch Available  (was: Open)

> DFSAdmin. Help messages are missing for -finalizeUpgrade and -metasave.
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-1626
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1626
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.13.0
>            Reporter: Konstantin Shvachko
>            Priority: Blocker
>             Fix For: 0.15.0
>
>         Attachments: HADOOP-1626.2.patch, HADOOP-1626.patch
>
>
> DFSAdmin.printHelp() does not print help for the two commands above.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-1626) DFSAdmin. Help messages are missing for -finalizeUpgrade and -metasave.

Posted by "lohit vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

lohit vijayarenu updated HADOOP-1626:
-------------------------------------

    Attachment: HADOOP-1626.2.patch

Updated patch with few more changes suggested by Nigel.
Thanks!

> DFSAdmin. Help messages are missing for -finalizeUpgrade and -metasave.
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-1626
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1626
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.13.0
>            Reporter: Konstantin Shvachko
>            Priority: Blocker
>             Fix For: 0.15.0
>
>         Attachments: HADOOP-1626.2.patch, HADOOP-1626.patch
>
>
> DFSAdmin.printHelp() does not print help for the two commands above.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-1626) DFSAdmin. Help messages are missing for -finalizeUpgrade and -metasave.

Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531951 ] 

Nigel Daley commented on HADOOP-1626:
-------------------------------------

+1 code review.

> DFSAdmin. Help messages are missing for -finalizeUpgrade and -metasave.
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-1626
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1626
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.13.0
>            Reporter: Konstantin Shvachko
>            Priority: Blocker
>             Fix For: 0.15.0
>
>         Attachments: HADOOP-1626.2.patch, HADOOP-1626.patch
>
>
> DFSAdmin.printHelp() does not print help for the two commands above.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-1626) DFSAdmin. Help messages are missing for -finalizeUpgrade and -metasave.

Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

dhruba borthakur updated HADOOP-1626:
-------------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed this. Thanks Lohit!

> DFSAdmin. Help messages are missing for -finalizeUpgrade and -metasave.
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-1626
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1626
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.13.0
>            Reporter: Konstantin Shvachko
>            Assignee: lohit vijayarenu
>            Priority: Blocker
>             Fix For: 0.15.0
>
>         Attachments: HADOOP-1626.2.patch, HADOOP-1626.patch
>
>
> DFSAdmin.printHelp() does not print help for the two commands above.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-1626) DFSAdmin. Help messages are missing for -finalizeUpgrade and -metasave.

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-1626:
----------------------------------

    Priority: Blocker  (was: Minor)

It is important to update the command line help when new commands are added.

> DFSAdmin. Help messages are missing for -finalizeUpgrade and -metasave.
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-1626
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1626
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.13.0
>            Reporter: Konstantin Shvachko
>            Priority: Blocker
>             Fix For: 0.15.0
>
>
> DFSAdmin.printHelp() does not print help for the two commands above.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-1626) DFSAdmin. Help messages are missing for -finalizeUpgrade and -metasave.

Posted by "lohit vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

lohit vijayarenu updated HADOOP-1626:
-------------------------------------

    Attachment: HADOOP-1626.patch

Attached is a patch which includes help message for -finalizeUpgrade and -metasave

Below is the help message.

[lohit@ucdev27 hadoop-trunk]$ hadoop dfsadmin -help finalizeUpgrade
-finalizeUpgrade: Finalize upgrade of DFS.
                Datanodes delete their old version working directories,
                followed by namenode removing its own and checkpoints in it.
                This completes the upgrade process.

[lohit@ucdev27 hadoop-trunk]$ hadoop dfsadmin -help metasave
-metasave <filename>:   Save namenode's primary data structures
                to <filename> in directory specified by hadoop.log.dir property.
                <filename> contains one line for each of the following
                        1. Datanodes heart beating with Namenode
                        2. Blocks waiting to be replicated
                        3. Blocks currrently being replicated
                        4. Blocls waiting to be deleted

[lohit@ucdev27 hadoop-trunk]$

> DFSAdmin. Help messages are missing for -finalizeUpgrade and -metasave.
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-1626
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1626
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.13.0
>            Reporter: Konstantin Shvachko
>            Priority: Blocker
>             Fix For: 0.15.0
>
>         Attachments: HADOOP-1626.patch
>
>
> DFSAdmin.printHelp() does not print help for the two commands above.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.