[jira] [Comment Edited] (ATLAS-3092) Atlas Plugin ClassLoader Doesn't Restore Thread ClassLoader

["Shawn Weeks (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ATLAS-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800603#comment-16800603 ] 

Shawn Weeks edited comment on ATLAS-3092 at 3/25/19 11:51 AM:
--------------------------------------------------------------

I believe this is probably incorrect. You’ll need to save the current threads class loader during the activate step. The class loader saved by the class constructor is almost always going to be different then the class loader the current thread had prior to calling activate.


was (Author: absolutesantaja):
I believe this is still incorrect. You’ll need to save the current threads class loader during the activate step. The class loader saved by the class constructor is almost always going to be different then the class loader the current thread had prior to calling activate. 

> Atlas Plugin ClassLoader Doesn't Restore Thread ClassLoader
> -----------------------------------------------------------
>
>                 Key: ATLAS-3092
>                 URL: https://issues.apache.org/jira/browse/ATLAS-3092
>             Project: Atlas
>          Issue Type: Bug
>            Reporter: Shawn Weeks
>            Priority: Minor
>         Attachments: ALAS-3092-AtlasPluginClassLoader-for-UDF.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently when the AtlasPluginClassLoader is deactivated it sets the current threads class loader to class loader that was active when the class was instantiated. In applications like Hive where a single thread may be shared among multiple sessions each with its own class loader this is breaking class loading for UDFs. The deactivate method should set the current threads class loader back to the class loader that was set when activate was called.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)