You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by clebertsuconic <gi...@git.apache.org> on 2015/03/16 23:54:33 UTC
[GitHub] activemq-6 pull request: ACTIVEMQ6-89 Interceptors on Stomp
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-6/pull/191
ACTIVEMQ6-89 Interceptors on Stomp
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic/activemq-6 mastanik
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-6/pull/191.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #191
----
commit c796e37c9c097af7c03c3df8841e41d3e7b4117d
Author: nberdikov <nb...@groupon.com>
Date: 2015-03-13T09:29:33Z
ACTIVEMQ6-89 Added possibility to intercept stomp frames
https://issues.apache.org/jira/browse/ACTIVEMQ6-89
This was originally contributed at #182. We have squashed the commits and rebased them here
This closes #182
commit 63ad8eba128efd5e46401530c6dbf5b96fb8fcaf
Author: Clebert Suconic <cl...@apache.org>
Date: 2015-03-16T19:11:25Z
ACTIVEMQ6-89 Refactored stomp support contributed
https://issues.apache.org/jira/browse/ACTIVEMQ6-89
I have done a lot of refactoring on this. So we can a different version of the interceptor for each protocol based on a base class now.
Just an abstract class over Stomp would be a bit hacky... this is a better approach.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: ACTIVEMQ6-89 Interceptors on Stomp
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-6/pull/191#issuecomment-82316330
Only after the release please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: ACTIVEMQ6-89 Interceptors on Stomp
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-6/pull/191#issuecomment-81987236
DO NOT MERGE THIS YET... there are test failures on the integration tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: ACTIVEMQ6-89 Interceptors on Stomp and so...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-6/pull/191
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: ACTIVEMQ6-89 Interceptors on Stomp
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the pull request:
https://github.com/apache/activemq-6/pull/191#issuecomment-82264396
@clebertsuconic This was probably mentioned earlier, but this seems like a considerable change. Can we hold off merging until after the release. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: ACTIVEMQ6-89 Interceptors on Stomp
Posted by mastanik <gi...@git.apache.org>.
Github user mastanik commented on the pull request:
https://github.com/apache/activemq-6/pull/191#issuecomment-82243335
looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: ACTIVEMQ6-89 Interceptors on Stomp and so...
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the pull request:
https://github.com/apache/activemq-6/pull/191#issuecomment-88107925
Looks good @clebertsuconic . Ack.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---