You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Gordon Sim <gs...@redhat.com> on 2013/11/01 13:45:46 UTC

Re: Review Request 15083: Add ability create, delete and list objects of arbitrary types

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15083/
-----------------------------------------------------------

(Updated Nov. 1, 2013, 12:45 p.m.)


Review request for qpid, Justin Ross, Kenneth Giusti, Jakub Scholz, and Ted Ross.


Changes
-------

This update improves the formatting of the 'list' action. The key issue there is in choosing which attributes to display, since for some types there are too many to work well in a simple table. The approach taken here is to (a) allow a hardcoded set of attributes for specific types, (b) allow the attributes shown to be controlled via a --show-property option and (c) if no other determination can be made, just show the first (where order is somewhat random, but name is always first) 6 attributes.

So e.g. qpid-config list exchange will by default display the hardcoded set of attributes name, type and durable
        qpid-config list exchange --show-property name --show-property bindingCount  will show the name and the binding count

Further improvements would be possible and of course the hardcoded defaults can be tweaked, but this seems like a reasonable first step.


Bugs: QPID-5277
    https://issues.apache.org/jira/browse/QPID-5277


Repository: qpid


Description
-------

The qpid-config utilty currently allows queues, exchanges and bindings to be created, but doesn't support other types.

Having a generic mechanism for create, delete and list would be very useful as it would mean the tool could be used for any entity types added (even if optional). Specifically this would eliminate the need for the current qpidt test utility in managing the various new 1.0 related entities.

With attached patch you can do e.g.

qpid-config add domain my-domain --argument url=localhost:6666 
qpid-config list domain
qpid-config del domain

The existing functions and options of qpid-config are not altered.


Diffs (updated)
-----

  /trunk/qpid/tools/src/py/qpid-config 1537889 
  /trunk/qpid/tools/src/py/qpidtoollibs/broker.py 1537889 

Diff: https://reviews.apache.org/r/15083/diff/


Testing
-------


Thanks,

Gordon Sim


Re: Review Request 15083: Add ability create, delete and list objects of arbitrary types

Posted by Alan Conway <ac...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15083/#review28018
-----------------------------------------------------------

Ship it!


Ship It!

- Alan Conway


On Nov. 1, 2013, 12:45 p.m., Gordon Sim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15083/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2013, 12:45 p.m.)
> 
> 
> Review request for qpid, Justin Ross, Kenneth Giusti, Jakub Scholz, and Ted Ross.
> 
> 
> Bugs: QPID-5277
>     https://issues.apache.org/jira/browse/QPID-5277
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> The qpid-config utilty currently allows queues, exchanges and bindings to be created, but doesn't support other types.
> 
> Having a generic mechanism for create, delete and list would be very useful as it would mean the tool could be used for any entity types added (even if optional). Specifically this would eliminate the need for the current qpidt test utility in managing the various new 1.0 related entities.
> 
> With attached patch you can do e.g.
> 
> qpid-config add domain my-domain --argument url=localhost:6666 
> qpid-config list domain
> qpid-config del domain
> 
> The existing functions and options of qpid-config are not altered.
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/tools/src/py/qpid-config 1537889 
>   /trunk/qpid/tools/src/py/qpidtoollibs/broker.py 1537889 
> 
> Diff: https://reviews.apache.org/r/15083/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gordon Sim
> 
>


Re: Review Request 15083: Add ability create, delete and list objects of arbitrary types

Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15083/#review28009
-----------------------------------------------------------

Ship it!


Very nice addition to qpid-config!  One *minor* nit - I didn't see the "list" option listed in the qpid-config --help usage summary.  Otherwise, ship it!

- Kenneth Giusti


On Nov. 1, 2013, 12:45 p.m., Gordon Sim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15083/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2013, 12:45 p.m.)
> 
> 
> Review request for qpid, Justin Ross, Kenneth Giusti, Jakub Scholz, and Ted Ross.
> 
> 
> Bugs: QPID-5277
>     https://issues.apache.org/jira/browse/QPID-5277
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> The qpid-config utilty currently allows queues, exchanges and bindings to be created, but doesn't support other types.
> 
> Having a generic mechanism for create, delete and list would be very useful as it would mean the tool could be used for any entity types added (even if optional). Specifically this would eliminate the need for the current qpidt test utility in managing the various new 1.0 related entities.
> 
> With attached patch you can do e.g.
> 
> qpid-config add domain my-domain --argument url=localhost:6666 
> qpid-config list domain
> qpid-config del domain
> 
> The existing functions and options of qpid-config are not altered.
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/tools/src/py/qpid-config 1537889 
>   /trunk/qpid/tools/src/py/qpidtoollibs/broker.py 1537889 
> 
> Diff: https://reviews.apache.org/r/15083/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gordon Sim
> 
>


Re: Review Request 15083: Add ability create, delete and list objects of arbitrary types

Posted by Gordon Sim <gs...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15083/
-----------------------------------------------------------

(Updated Nov. 1, 2013, 6:23 p.m.)


Review request for qpid, Justin Ross, Kenneth Giusti, Jakub Scholz, and Ted Ross.


Changes
-------

Update to usage. Also removed qpidt.


Bugs: QPID-5277
    https://issues.apache.org/jira/browse/QPID-5277


Repository: qpid


Description
-------

The qpid-config utilty currently allows queues, exchanges and bindings to be created, but doesn't support other types.

Having a generic mechanism for create, delete and list would be very useful as it would mean the tool could be used for any entity types added (even if optional). Specifically this would eliminate the need for the current qpidt test utility in managing the various new 1.0 related entities.

With attached patch you can do e.g.

qpid-config add domain my-domain --argument url=localhost:6666 
qpid-config list domain
qpid-config del domain

The existing functions and options of qpid-config are not altered.


Diffs (updated)
-----

  /trunk/qpid/cpp/src/tests/qpidt 1537889 
  /trunk/qpid/tools/src/py/qpid-config 1537889 
  /trunk/qpid/tools/src/py/qpidtoollibs/broker.py 1537889 

Diff: https://reviews.apache.org/r/15083/diff/


Testing
-------


Thanks,

Gordon Sim