You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by as...@apache.org on 2009/08/01 17:38:33 UTC

svn commit: r799889 - in /ofbiz/trunk/applications: order/servicedef/services.xml product/servicedef/services_shipment.xml

Author: ashish
Date: Sat Aug  1 15:38:32 2009
New Revision: 799889

URL: http://svn.apache.org/viewvc?rev=799889&view=rev
Log:
This was making my life difficult since last few days.
Although I have't had a chance to look on this issue, but now here you go.

The subject missing error was coming on the console again and again although it was sending emails.

In case of any error like missing subject it was sending email again and again. 
I see the orderComplete notification four times on my machine.

Here is the sample log message of one of the service sendShipmentCompleteNotification which was failing:

Exception: org.ofbiz.service.ServiceValidationException
Message: Unknown parameter found: [sendShipmentCompleteNotification.subject]
---- stack trace ---------------------------------------------------------------
org.ofbiz.service.ServiceValidationException: Unknown parameter found: [sendShipmentCompleteNotification.subject]
org.ofbiz.service.ModelService.validate(ModelService.java:638)
org.ofbiz.service.ModelService.validate(ModelService.java:552)
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:482)
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:221)
org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:159)
org.ofbiz.service.job.GenericServiceJob.exec(GenericServiceJob.java:70)
org.ofbiz.service.job.JobInvoker.run(JobInvoker.java:242)
java.lang.Thread.run(Thread.java:619)

Modified:
    ofbiz/trunk/applications/order/servicedef/services.xml
    ofbiz/trunk/applications/product/servicedef/services_shipment.xml

Modified: ofbiz/trunk/applications/order/servicedef/services.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/servicedef/services.xml?rev=799889&r1=799888&r2=799889&view=diff
==============================================================================
--- ofbiz/trunk/applications/order/servicedef/services.xml (original)
+++ ofbiz/trunk/applications/order/servicedef/services.xml Sat Aug  1 15:38:32 2009
@@ -42,12 +42,12 @@
         <attribute name="note" type="String" mode="IN" optional="true"/>
         <attribute name="temporaryAnonymousUserLogin" type="org.ofbiz.entity.GenericValue" mode="IN" optional="true"/>
         <attribute name="messageWrapper" type="org.ofbiz.service.mail.MimeMessageWrapper" mode="OUT"/>
+        <attribute name="subject" type="String" mode="OUT" optional="true"/>
     </service>
     <service name="sendOrderConfirmation" engine="java" require-new-transaction="true" max-retry="3"
             location="org.ofbiz.order.order.OrderServices" invoke="sendOrderConfirmNotification">
         <description>Send a order confirmation</description>
         <implements service="orderNotificationInterface"/>
-        <attribute name="subject" type="String" mode="OUT" optional="true"/>
     </service>
     <service name="sendOrderChangeNotification" engine="java" require-new-transaction="true" max-retry="3"
             location="org.ofbiz.order.order.OrderServices" invoke="sendOrderChangeNotification">

Modified: ofbiz/trunk/applications/product/servicedef/services_shipment.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/servicedef/services_shipment.xml?rev=799889&r1=799888&r2=799889&view=diff
==============================================================================
--- ofbiz/trunk/applications/product/servicedef/services_shipment.xml (original)
+++ ofbiz/trunk/applications/product/servicedef/services_shipment.xml Sat Aug  1 15:38:32 2009
@@ -879,6 +879,7 @@
         <attribute name="screenUri" type="String" mode="IN" optional="true"/>
         <attribute name="comments" type="String" mode="IN" optional="true"/>
         <attribute name="body" type="String" mode="OUT" optional="true"/>
+        <attribute name="subject" type="String" mode="OUT" optional="true"/>
         <attribute name="messageWrapper" type="org.ofbiz.service.mail.MimeMessageWrapper" mode="OUT"/>
     </service>
     <service name="updateIssuanceShipmentAndPoOnReceiveInventory" engine="simple"