You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@linkis.apache.org by GitBox <gi...@apache.org> on 2021/11/02 01:59:24 UTC
[GitHub] [incubator-linkis] lordk911 opened a new pull request #1058: fix issue 1057 : support subdir to be 'zip' and 'unzip'
lordk911 opened a new pull request #1058:
URL: https://github.com/apache/incubator-linkis/pull/1058
fix issue [1057](https://github.com/apache/incubator-linkis/issues/1057#issue-1041204222) : support subdir to be 'zip' and 'unzip'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong commented on a change in pull request #1058: fix issue 1057 : support subdir to be 'zip' and 'unzip'
Posted by GitBox <gi...@apache.org>.
peacewong commented on a change in pull request #1058:
URL: https://github.com/apache/incubator-linkis/pull/1058#discussion_r740685102
##########
File path: linkis-commons/linkis-common/src/main/java/org/apache/linkis/common/io/Fs.java
##########
@@ -52,4 +52,8 @@
public abstract boolean renameTo(FsPath oldDest, FsPath newDest) throws IOException;
+ public abstract boolean mkdir(FsPath dest) throws IOException;
Review comment:
Hello, the code implemented by the method is not uploaded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org
[GitHub] [incubator-linkis] lordk911 commented on a change in pull request #1058: fix issue 1057 : support subdir to be 'zip' and 'unzip'
Posted by GitBox <gi...@apache.org>.
lordk911 commented on a change in pull request #1058:
URL: https://github.com/apache/incubator-linkis/pull/1058#discussion_r740696777
##########
File path: linkis-commons/linkis-common/src/main/java/org/apache/linkis/common/io/Fs.java
##########
@@ -52,4 +52,8 @@
public abstract boolean renameTo(FsPath oldDest, FsPath newDest) throws IOException;
+ public abstract boolean mkdir(FsPath dest) throws IOException;
Review comment:
interface Fs in module linkis-common have a direct implement abstract class FileSystem in module linkis-storage. The method add into Fs have already IN FileSystem before this PR
##########
File path: linkis-commons/linkis-common/src/main/java/org/apache/linkis/common/io/Fs.java
##########
@@ -52,4 +52,8 @@
public abstract boolean renameTo(FsPath oldDest, FsPath newDest) throws IOException;
+ public abstract boolean mkdir(FsPath dest) throws IOException;
Review comment:
I have remove the the abstract method mkdir\mkdirs from abstract class FileSystem and lift them to interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong merged pull request #1058: fix issue 1057 : support subdir to be 'zip' and 'unzip'
Posted by GitBox <gi...@apache.org>.
peacewong merged pull request #1058:
URL: https://github.com/apache/incubator-linkis/pull/1058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org
[GitHub] [incubator-linkis] lordk911 commented on a change in pull request #1058: fix issue 1057 : support subdir to be 'zip' and 'unzip'
Posted by GitBox <gi...@apache.org>.
lordk911 commented on a change in pull request #1058:
URL: https://github.com/apache/incubator-linkis/pull/1058#discussion_r740706655
##########
File path: linkis-commons/linkis-common/src/main/java/org/apache/linkis/common/io/Fs.java
##########
@@ -52,4 +52,8 @@
public abstract boolean renameTo(FsPath oldDest, FsPath newDest) throws IOException;
+ public abstract boolean mkdir(FsPath dest) throws IOException;
Review comment:
I have remove the the abstract method mkdir\mkdirs from abstract class FileSystem and lift them to interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong commented on a change in pull request #1058: fix issue 1057 : support subdir to be 'zip' and 'unzip'
Posted by GitBox <gi...@apache.org>.
peacewong commented on a change in pull request #1058:
URL: https://github.com/apache/incubator-linkis/pull/1058#discussion_r740685102
##########
File path: linkis-commons/linkis-common/src/main/java/org/apache/linkis/common/io/Fs.java
##########
@@ -52,4 +52,8 @@
public abstract boolean renameTo(FsPath oldDest, FsPath newDest) throws IOException;
+ public abstract boolean mkdir(FsPath dest) throws IOException;
Review comment:
Hello, the code implemented by the method is not uploaded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong commented on a change in pull request #1058: fix issue 1057 : support subdir to be 'zip' and 'unzip'
Posted by GitBox <gi...@apache.org>.
peacewong commented on a change in pull request #1058:
URL: https://github.com/apache/incubator-linkis/pull/1058#discussion_r740685102
##########
File path: linkis-commons/linkis-common/src/main/java/org/apache/linkis/common/io/Fs.java
##########
@@ -52,4 +52,8 @@
public abstract boolean renameTo(FsPath oldDest, FsPath newDest) throws IOException;
+ public abstract boolean mkdir(FsPath dest) throws IOException;
Review comment:
Hello, the code implemented by the method is not uploaded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org
[GitHub] [incubator-linkis] lordk911 commented on a change in pull request #1058: fix issue 1057 : support subdir to be 'zip' and 'unzip'
Posted by GitBox <gi...@apache.org>.
lordk911 commented on a change in pull request #1058:
URL: https://github.com/apache/incubator-linkis/pull/1058#discussion_r740696777
##########
File path: linkis-commons/linkis-common/src/main/java/org/apache/linkis/common/io/Fs.java
##########
@@ -52,4 +52,8 @@
public abstract boolean renameTo(FsPath oldDest, FsPath newDest) throws IOException;
+ public abstract boolean mkdir(FsPath dest) throws IOException;
Review comment:
interface Fs in module linkis-common have a direct implement abstract class FileSystem in module linkis-storage. The method add into Fs have already IN FileSystem before this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org
[GitHub] [incubator-linkis] lordk911 commented on a change in pull request #1058: fix issue 1057 : support subdir to be 'zip' and 'unzip'
Posted by GitBox <gi...@apache.org>.
lordk911 commented on a change in pull request #1058:
URL: https://github.com/apache/incubator-linkis/pull/1058#discussion_r740696777
##########
File path: linkis-commons/linkis-common/src/main/java/org/apache/linkis/common/io/Fs.java
##########
@@ -52,4 +52,8 @@
public abstract boolean renameTo(FsPath oldDest, FsPath newDest) throws IOException;
+ public abstract boolean mkdir(FsPath dest) throws IOException;
Review comment:
interface Fs in module linkis-common have a direct implement abstract class FileSystem in module linkis-storage. The method add into Fs have already IN FileSystem before this PR
##########
File path: linkis-commons/linkis-common/src/main/java/org/apache/linkis/common/io/Fs.java
##########
@@ -52,4 +52,8 @@
public abstract boolean renameTo(FsPath oldDest, FsPath newDest) throws IOException;
+ public abstract boolean mkdir(FsPath dest) throws IOException;
Review comment:
I have remove the the abstract method mkdir\mkdirs from abstract class FileSystem and lift them to interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org