You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by if...@apache.org on 2022/07/01 23:35:37 UTC

[rocketmq-client-cpp] branch master updated: pass by reference

This is an automated email from the ASF dual-hosted git repository.

ifplusor pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq-client-cpp.git


The following commit(s) were added to refs/heads/master by this push:
     new a9d76e2  pass by reference
a9d76e2 is described below

commit a9d76e2c5b325d73a560fe73aa59b603636f4aed
Author: SRC-xiaojin <zt...@163.com>
AuthorDate: Fri Jul 1 00:08:03 2022 +0800

    pass by reference
    
    (cherry picked from commit 1ba67b60a35bbc51f8ccbd7fb559d2513712b732)
---
 src/producer/DefaultMQProducerImpl.cpp | 2 +-
 src/producer/DefaultMQProducerImpl.h   | 2 +-
 src/protocol/ConsumerRunningInfo.cpp   | 4 ++--
 src/protocol/ConsumerRunningInfo.h     | 4 ++--
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/producer/DefaultMQProducerImpl.cpp b/src/producer/DefaultMQProducerImpl.cpp
index 6e16ce7..87d44f4 100644
--- a/src/producer/DefaultMQProducerImpl.cpp
+++ b/src/producer/DefaultMQProducerImpl.cpp
@@ -706,7 +706,7 @@ bool DefaultMQProducerImpl::dealWithMessageTrace() {
   registerSendMessageHook(hook);
   return true;
 }
-bool DefaultMQProducerImpl::isMessageTraceTopic(string source) {
+bool DefaultMQProducerImpl::isMessageTraceTopic(const string& source) {
   return source.find(TraceContant::TRACE_TOPIC) != string::npos;
 }
 bool DefaultMQProducerImpl::hasSendMessageHook() {
diff --git a/src/producer/DefaultMQProducerImpl.h b/src/producer/DefaultMQProducerImpl.h
index 637c193..d2eb187 100644
--- a/src/producer/DefaultMQProducerImpl.h
+++ b/src/producer/DefaultMQProducerImpl.h
@@ -110,7 +110,7 @@ class DefaultMQProducerImpl : public MQProducer {
   bool dealWithNameSpace();
   void logConfigs();
   bool dealWithMessageTrace();
-  bool isMessageTraceTopic(std::string topic);
+  bool isMessageTraceTopic(const std::string& topic);
   bool hasSendMessageHook();
   void registerSendMessageHook(std::shared_ptr<SendMessageHook>& hook);
   void executeSendMessageHookBefore(SendMessageContext* context);
diff --git a/src/protocol/ConsumerRunningInfo.cpp b/src/protocol/ConsumerRunningInfo.cpp
index 08e5b2c..6ef5571 100644
--- a/src/protocol/ConsumerRunningInfo.cpp
+++ b/src/protocol/ConsumerRunningInfo.cpp
@@ -42,7 +42,7 @@ const map<MessageQueue, ProcessQueueInfo> ConsumerRunningInfo::getMqTable() cons
   return mqTable;
 }
 
-void ConsumerRunningInfo::setMqTable(MessageQueue queue, ProcessQueueInfo queueInfo) {
+void ConsumerRunningInfo::setMqTable(const MessageQueue& queue, const ProcessQueueInfo& queueInfo) {
   mqTable[queue] = queueInfo;
 }
 
@@ -50,7 +50,7 @@ const map<string, ConsumeStats> ConsumerRunningInfo::getStatusTable() const {
   return statusTable;
 }
 
-void ConsumerRunningInfo::setStatusTable(string topic, ConsumeStats consumeStats) {
+void ConsumerRunningInfo::setStatusTable(const string& topic, const ConsumeStats& consumeStats) {
   statusTable[topic] = consumeStats;
 }
 
diff --git a/src/protocol/ConsumerRunningInfo.h b/src/protocol/ConsumerRunningInfo.h
index f20ca2f..e61c43d 100644
--- a/src/protocol/ConsumerRunningInfo.h
+++ b/src/protocol/ConsumerRunningInfo.h
@@ -47,9 +47,9 @@ class ConsumerRunningInfo {
   void setProperties(const map<string, string>& input_properties);
   void setProperty(const string& key, const string& value);
   const map<MessageQueue, ProcessQueueInfo> getMqTable() const;
-  void setMqTable(MessageQueue queue, ProcessQueueInfo queueInfo);
+  void setMqTable(const MessageQueue& queue, const ProcessQueueInfo& queueInfo);
   const map<string, ConsumeStats> getStatusTable() const;
-  void setStatusTable(string topic, ConsumeStats consumeStats);
+  void setStatusTable(const string& topic, const ConsumeStats& consumeStats);
   const vector<SubscriptionData> getSubscriptionSet() const;
   void setSubscriptionSet(const vector<SubscriptionData>& input_subscriptionSet);
   const string getJstack() const;