[jira] [Closed] (OFBIZ-9787) [FB] Package org.apache.ofbiz.product.supplier

["Michael Brohl (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-9787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Brohl closed OFBIZ-9787.
--------------------------------
       Resolution: Implemented
    Fix Version/s: Upcoming Release

Thanks Julian,

your patch is in trunk r1817646. 

> [FB] Package org.apache.ofbiz.product.supplier
> ----------------------------------------------
>
>                 Key: OFBIZ-9787
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9787
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: Trunk
>            Reporter: Julian Leichert
>            Assignee: Michael Brohl
>            Priority: Minor
>             Fix For: Upcoming Release
>
>         Attachments: OFBIZ-9787_org.apache.ofbiz.product.supplier_bugfixes.patch
>
>
> SupplierProductServices.java:58, DLS_DEAD_LOCAL_STORE
> - DLS: Dead store to results in org.apache.ofbiz.product.supplier.SupplierProductServices.getSuppliersForProduct(DispatchContext, Map)
> This instruction assigns a value to a local variable, but the value is not read or used in any subsequent instruction. Often, this indicates an error, because the value computed is never used.
> Note that Sun's javac compiler often generates dead stores for final local variables. Because FindBugs is a bytecode-based tool, there is no easy way to eliminate these false positives.
> SupplierProductServices.java:130, DLS_DEAD_LOCAL_STORE
> - DLS: Dead store to results in org.apache.ofbiz.product.supplier.SupplierProductServices.convertFeaturesForSupplier(DispatchContext, Map)
> This instruction assigns a value to a local variable, but the value is not read or used in any subsequent instruction. Often, this indicates an error, because the value computed is never used.
> Note that Sun's javac compiler often generates dead stores for final local variables. Because FindBugs is a bytecode-based tool, there is no easy way to eliminate these false positives. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)