You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/03/21 01:19:16 UTC
Review Request 57798: Fixed Java V1 Framework unit test for macOS.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57798/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Gilbert Song.
Bugs: MESOS-7270
https://issues.apache.org/jira/browse/MESOS-7270
Repository: mesos
Description
-------
Fixed Java V1 Framework unit test for macOS. This is the same fix as in https://github.com/apache/mesos/blob/master/src/examples/java/TestFramework.java#L265.
Diffs
-----
src/examples/java/V1TestFramework.java df352ff08c66150483f5be3e52bce150becc7ab2
Diff: https://reviews.apache.org/r/57798/diff/1/
Testing
-------
Modified ExamplesTest.V1JavaFramework. Tested under macOS 10.12.3.
Thanks,
Chun-Hung Hsiao
Re: Review Request 57798: Fixed Java V1 Framework unit test for macOS.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57798/#review169614
-----------------------------------------------------------
Fix it, then Ship it!
LGTM! Good job, Chun!
src/examples/java/V1TestFramework.java
Lines 382-390 (patched)
<https://reviews.apache.org/r/57798/#comment242056>
Chun, I am assuming you are using `XXX` here since not sure what is correct in style. We may probably make it in this way:
```
// NOTE: Copied from src/examples/jave/TestFramework.java:
// For this test to pass reliably on some platforms, this sleep is
// required to ensure that the SchedulerDriver teardown is complete
// before the JVM starts running native object destructors after
// System.exit() is called. 500ms proved successful in test runs,
// but on a heavily loaded machine it might not.
//
// TODO(greg): Ideally, we would inspect the status of the driver
// and its associated tasks via the Java API and wait until their
// teardown is complete to exit.
```
- Gilbert Song
On March 20, 2017, 6:19 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57798/
> -----------------------------------------------------------
>
> (Updated March 20, 2017, 6:19 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Gilbert Song.
>
>
> Bugs: MESOS-7270
> https://issues.apache.org/jira/browse/MESOS-7270
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed Java V1 Framework unit test for macOS. This is the same fix as in https://github.com/apache/mesos/blob/master/src/examples/java/TestFramework.java#L265.
>
>
> Diffs
> -----
>
> src/examples/java/V1TestFramework.java df352ff08c66150483f5be3e52bce150becc7ab2
>
>
> Diff: https://reviews.apache.org/r/57798/diff/1/
>
>
> Testing
> -------
>
> Modified ExamplesTest.V1JavaFramework. Tested under macOS 10.12.3.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 57798: Fixed Java V1 Framework unit test for macOS.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57798/#review169529
-----------------------------------------------------------
Patch looks great!
Reviews applied: [57798]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 21, 2017, 1:19 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57798/
> -----------------------------------------------------------
>
> (Updated March 21, 2017, 1:19 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Gilbert Song.
>
>
> Bugs: MESOS-7270
> https://issues.apache.org/jira/browse/MESOS-7270
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed Java V1 Framework unit test for macOS. This is the same fix as in https://github.com/apache/mesos/blob/master/src/examples/java/TestFramework.java#L265.
>
>
> Diffs
> -----
>
> src/examples/java/V1TestFramework.java df352ff08c66150483f5be3e52bce150becc7ab2
>
>
> Diff: https://reviews.apache.org/r/57798/diff/1/
>
>
> Testing
> -------
>
> Modified ExamplesTest.V1JavaFramework. Tested under macOS 10.12.3.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 57798: Fixed Java V1 Framework unit test for macOS.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57798/#review169655
-----------------------------------------------------------
Ship it!
LGTM!
- Anand Mazumdar
On March 22, 2017, 12:01 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57798/
> -----------------------------------------------------------
>
> (Updated March 22, 2017, 12:01 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Gilbert Song.
>
>
> Bugs: MESOS-7270
> https://issues.apache.org/jira/browse/MESOS-7270
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a 500ms delay in the main thread to wait for the scheduler driver to stop before program termination in the Java V1 Framework unit test to avoid test failure under macOS.
>
>
> Diffs
> -----
>
> src/examples/java/V1TestFramework.java df352ff08c66150483f5be3e52bce150becc7ab2
>
>
> Diff: https://reviews.apache.org/r/57798/diff/2/
>
>
> Testing
> -------
>
> Modified ExamplesTest.V1JavaFramework. Compiled and ran the Java V1 Framework test several times under macOS 10.12.3 without failure (The test fails before the fix every time). Also tested under Ubuntu 16.04.2 LTS to verify that the change does not lead to any problem under Linux.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 57798: Fixed Java V1 Framework unit test for macOS.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57798/#review169657
-----------------------------------------------------------
Ship it!
Ship It!
- Chun-Hung Hsiao
On March 22, 2017, 12:01 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57798/
> -----------------------------------------------------------
>
> (Updated March 22, 2017, 12:01 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Gilbert Song.
>
>
> Bugs: MESOS-7270
> https://issues.apache.org/jira/browse/MESOS-7270
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a 500ms delay in the main thread to wait for the scheduler driver to stop before program termination in the Java V1 Framework unit test to avoid test failure under macOS.
>
>
> Diffs
> -----
>
> src/examples/java/V1TestFramework.java df352ff08c66150483f5be3e52bce150becc7ab2
>
>
> Diff: https://reviews.apache.org/r/57798/diff/2/
>
>
> Testing
> -------
>
> Modified ExamplesTest.V1JavaFramework. Compiled and ran the Java V1 Framework test several times under macOS 10.12.3 without failure (The test fails before the fix every time). Also tested under Ubuntu 16.04.2 LTS to verify that the change does not lead to any problem under Linux.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 57798: Fixed Java V1 Framework unit test for macOS.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57798/
-----------------------------------------------------------
(Updated March 22, 2017, 12:01 a.m.)
Review request for mesos, Anand Mazumdar and Gilbert Song.
Bugs: MESOS-7270
https://issues.apache.org/jira/browse/MESOS-7270
Repository: mesos
Description (updated)
-------
Added a 500ms delay in the main thread to wait for the scheduler driver to stop before program termination in the Java V1 Framework unit test to avoid test failure under macOS.
Diffs
-----
src/examples/java/V1TestFramework.java df352ff08c66150483f5be3e52bce150becc7ab2
Diff: https://reviews.apache.org/r/57798/diff/2/
Testing (updated)
-------
Modified ExamplesTest.V1JavaFramework. Compiled and ran the Java V1 Framework test several times under macOS 10.12.3 without failure (The test fails before the fix every time). Also tested under Ubuntu 16.04.2 LTS to verify that the change does not lead to any problem under Linux.
Thanks,
Chun-Hung Hsiao
Re: Review Request 57798: Fixed Java V1 Framework unit test for macOS.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57798/#review169646
-----------------------------------------------------------
Patch looks great!
Reviews applied: [57798]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 21, 2017, 9:33 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57798/
> -----------------------------------------------------------
>
> (Updated March 21, 2017, 9:33 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Gilbert Song.
>
>
> Bugs: MESOS-7270
> https://issues.apache.org/jira/browse/MESOS-7270
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed Java V1 Framework unit test for macOS.
>
>
> Diffs
> -----
>
> src/examples/java/V1TestFramework.java df352ff08c66150483f5be3e52bce150becc7ab2
>
>
> Diff: https://reviews.apache.org/r/57798/diff/2/
>
>
> Testing
> -------
>
> Modified ExamplesTest.V1JavaFramework. Tested under macOS 10.12.3.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 57798: Fixed Java V1 Framework unit test for macOS.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
> On March 21, 2017, 9:40 p.m., Anand Mazumdar wrote:
> > Looks good!
> >
> > Minor Nits:
> > - Can you add some more details about your changes in the `Description` field?
> > - Under `Testing Done`, can you add more details on how did you test this change?
Done. Thanks for the comments.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57798/#review169620
-----------------------------------------------------------
On March 21, 2017, 9:33 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57798/
> -----------------------------------------------------------
>
> (Updated March 21, 2017, 9:33 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Gilbert Song.
>
>
> Bugs: MESOS-7270
> https://issues.apache.org/jira/browse/MESOS-7270
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed Java V1 Framework unit test for macOS.
>
>
> Diffs
> -----
>
> src/examples/java/V1TestFramework.java df352ff08c66150483f5be3e52bce150becc7ab2
>
>
> Diff: https://reviews.apache.org/r/57798/diff/2/
>
>
> Testing
> -------
>
> Modified ExamplesTest.V1JavaFramework. Tested under macOS 10.12.3.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 57798: Fixed Java V1 Framework unit test for macOS.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57798/#review169620
-----------------------------------------------------------
Looks good!
Minor Nits:
- Can you add some more details about your changes in the `Description` field?
- Under `Testing Done`, can you add more details on how did you test this change?
- Anand Mazumdar
On March 21, 2017, 9:33 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57798/
> -----------------------------------------------------------
>
> (Updated March 21, 2017, 9:33 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Gilbert Song.
>
>
> Bugs: MESOS-7270
> https://issues.apache.org/jira/browse/MESOS-7270
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed Java V1 Framework unit test for macOS.
>
>
> Diffs
> -----
>
> src/examples/java/V1TestFramework.java df352ff08c66150483f5be3e52bce150becc7ab2
>
>
> Diff: https://reviews.apache.org/r/57798/diff/2/
>
>
> Testing
> -------
>
> Modified ExamplesTest.V1JavaFramework. Tested under macOS 10.12.3.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 57798: Fixed Java V1 Framework unit test for macOS.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57798/
-----------------------------------------------------------
(Updated March 21, 2017, 9:33 p.m.)
Review request for mesos, Anand Mazumdar and Gilbert Song.
Bugs: MESOS-7270
https://issues.apache.org/jira/browse/MESOS-7270
Repository: mesos
Description (updated)
-------
Fixed Java V1 Framework unit test for macOS.
Diffs (updated)
-----
src/examples/java/V1TestFramework.java df352ff08c66150483f5be3e52bce150becc7ab2
Diff: https://reviews.apache.org/r/57798/diff/2/
Changes: https://reviews.apache.org/r/57798/diff/1-2/
Testing
-------
Modified ExamplesTest.V1JavaFramework. Tested under macOS 10.12.3.
Thanks,
Chun-Hung Hsiao