You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/06/20 20:24:05 UTC
[GitHub] [incubator-mxnet] eric-haibin-lin opened a new pull request #18598: [WIP] graph executor c api removal
eric-haibin-lin opened a new pull request #18598:
URL: https://github.com/apache/incubator-mxnet/pull/18598
## Description ##
(Brief description on what this PR is about)
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [ ] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- For new C++ functions in header files, their functionalities and arguments are documented.
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on a change in pull request #18598: graph executor c api removal
Posted by GitBox <gi...@apache.org>.
ys2843 commented on a change in pull request #18598:
URL: https://github.com/apache/incubator-mxnet/pull/18598#discussion_r444362937
##########
File path: ci/jenkins/Jenkinsfile_website_full
##########
@@ -40,13 +40,7 @@ core_logic: {
utils.parallel_stage('Build Docs', [
custom_steps.docs_jekyll(),
- custom_steps.docs_c('libmxnet'),
custom_steps.docs_python('libmxnet'),
- custom_steps.docs_julia('libmxnet'),
Review comment:
Other versions of website except master are archived static files and their build process does not depend on any branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18598: graph executor c api removal
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #18598:
URL: https://github.com/apache/incubator-mxnet/pull/18598#discussion_r443918083
##########
File path: ci/jenkins/Jenkinsfile_website_full
##########
@@ -40,13 +40,7 @@ core_logic: {
utils.parallel_stage('Build Docs', [
custom_steps.docs_jekyll(),
- custom_steps.docs_c('libmxnet'),
custom_steps.docs_python('libmxnet'),
- custom_steps.docs_julia('libmxnet'),
Review comment:
@sandeep-krishnamurthy the problem here really is that the website defaults to the master version instead of the stable version. https://github.com/apache/incubator-mxnet/issues/18429
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #18598: graph executor c api removal
Posted by GitBox <gi...@apache.org>.
szha merged pull request #18598:
URL: https://github.com/apache/incubator-mxnet/pull/18598
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #18598: graph executor c api removal
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #18598:
URL: https://github.com/apache/incubator-mxnet/pull/18598#discussion_r443805244
##########
File path: ci/jenkins/Jenkinsfile_website_full
##########
@@ -40,13 +40,7 @@ core_logic: {
utils.parallel_stage('Build Docs', [
custom_steps.docs_jekyll(),
- custom_steps.docs_c('libmxnet'),
custom_steps.docs_python('libmxnet'),
- custom_steps.docs_julia('libmxnet'),
Review comment:
These front ends need to be developed on mxnet 2.0 as they depend on deprecated C API. For master branch, not showing them is intended. For other versions, if there’s anything broken, then the doc build logic needs fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] connorgoggins commented on a change in pull request #18598: graph executor c api removal
Posted by GitBox <gi...@apache.org>.
connorgoggins commented on a change in pull request #18598:
URL: https://github.com/apache/incubator-mxnet/pull/18598#discussion_r443789359
##########
File path: ci/jenkins/Jenkinsfile_website_full
##########
@@ -40,13 +40,7 @@ core_logic: {
utils.parallel_stage('Build Docs', [
custom_steps.docs_jekyll(),
- custom_steps.docs_c('libmxnet'),
custom_steps.docs_python('libmxnet'),
- custom_steps.docs_julia('libmxnet'),
Review comment:
Can we revert the merge of this PR and rebuild website ASAP?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on a change in pull request #18598: graph executor c api removal
Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy commented on a change in pull request #18598:
URL: https://github.com/apache/incubator-mxnet/pull/18598#discussion_r443915532
##########
File path: ci/jenkins/Jenkinsfile_website_full
##########
@@ -40,13 +40,7 @@ core_logic: {
utils.parallel_stage('Build Docs', [
custom_steps.docs_jekyll(),
- custom_steps.docs_c('libmxnet'),
custom_steps.docs_python('libmxnet'),
- custom_steps.docs_julia('libmxnet'),
Review comment:
@szha - if other versions are broken, my opinion is that needs to be fixed before this PR is merged. If not, are you saying it is expected and accepted breaking change in website master branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #18598: graph executor c api removal
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #18598:
URL: https://github.com/apache/incubator-mxnet/pull/18598#discussion_r443916607
##########
File path: ci/jenkins/Jenkinsfile_website_full
##########
@@ -40,13 +40,7 @@ core_logic: {
utils.parallel_stage('Build Docs', [
custom_steps.docs_jekyll(),
- custom_steps.docs_c('libmxnet'),
custom_steps.docs_python('libmxnet'),
- custom_steps.docs_julia('libmxnet'),
Review comment:
@sandeep-krishnamurthy I'm not aware of whether other versions are broken, hence the "if". The point I'm trying to make is that the other language bindings in previous versions, which are fully functional, shouldn't have their doc build logic dependent on master branch.
And yes, the master branch doc should not show language bindings until they are migrated to the new C API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on a change in pull request #18598: graph executor c api removal
Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy commented on a change in pull request #18598:
URL: https://github.com/apache/incubator-mxnet/pull/18598#discussion_r443918389
##########
File path: ci/jenkins/Jenkinsfile_website_full
##########
@@ -40,13 +40,7 @@ core_logic: {
utils.parallel_stage('Build Docs', [
custom_steps.docs_jekyll(),
- custom_steps.docs_c('libmxnet'),
custom_steps.docs_python('libmxnet'),
- custom_steps.docs_julia('libmxnet'),
Review comment:
Thanks. From my understanding, other version branches are not impacted, it is just the master. @ys2843 can confirm. If that is the case, what would be your recommendation for scala/java/r/c++ api in master version of website?
I think either we should remove from website API drop down or put a page saying it is work in progress.
@aaronmarkhama what do you suggest here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] connorgoggins commented on a change in pull request #18598: graph executor c api removal
Posted by GitBox <gi...@apache.org>.
connorgoggins commented on a change in pull request #18598:
URL: https://github.com/apache/incubator-mxnet/pull/18598#discussion_r443787172
##########
File path: ci/jenkins/Jenkinsfile_website_full
##########
@@ -40,13 +40,7 @@ core_logic: {
utils.parallel_stage('Build Docs', [
custom_steps.docs_jekyll(),
- custom_steps.docs_c('libmxnet'),
custom_steps.docs_python('libmxnet'),
- custom_steps.docs_julia('libmxnet'),
Review comment:
After this PR was merged, none of these docs are appearing on the MXNet website anymore. Why were these removed from the build steps?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18598: [WIP] graph executor c api removal
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18598:
URL: https://github.com/apache/incubator-mxnet/pull/18598#issuecomment-647041754
Hey @eric-haibin-lin , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [website, centos-gpu, centos-cpu, unix-gpu, sanity, edge, clang, windows-cpu, unix-cpu, miscellaneous, windows-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] connorgoggins commented on a change in pull request #18598: graph executor c api removal
Posted by GitBox <gi...@apache.org>.
connorgoggins commented on a change in pull request #18598:
URL: https://github.com/apache/incubator-mxnet/pull/18598#discussion_r443787457
##########
File path: ci/jenkins/Jenkinsfile_website_full
##########
@@ -40,13 +40,7 @@ core_logic: {
utils.parallel_stage('Build Docs', [
custom_steps.docs_jekyll(),
- custom_steps.docs_c('libmxnet'),
custom_steps.docs_python('libmxnet'),
- custom_steps.docs_julia('libmxnet'),
Review comment:
See #18604.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org