You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2020/08/07 20:41:41 UTC
[GitHub] [orc] dongjoon-hyun commented on a change in pull request #524: ZSTD_STATIC_LIB_NAME: Avoid double .a extensions
dongjoon-hyun commented on a change in pull request #524:
URL: https://github.com/apache/orc/pull/524#discussion_r467259161
##########
File path: cmake_modules/FindZSTD.cmake
##########
@@ -24,7 +24,7 @@ endif()
message (STATUS "ZSTD_HOME: ${ZSTD_HOME}")
if (NOT ZSTD_STATIC_LIB_NAME)
- set (ZSTD_STATIC_LIB_NAME ${CMAKE_STATIC_LIBRARY_PREFIX}zstd)
+ set (ZSTD_STATIC_LIB_NAME ${CMAKE_STATIC_LIBRARY_PREFIX}zstd${CMAKE_STATIC_LIBRARY_SUFFIX})
Review comment:
I understand the use case, but this is used at line 35, `find_library (ZSTD_LIBRARIES NAMES ${ZSTD_STATIC_LIB_NAME} HINTS`. Usually, `find_library` doesn't require suffix, does it?
##########
File path: cmake_modules/FindZSTD.cmake
##########
@@ -24,7 +24,7 @@ endif()
message (STATUS "ZSTD_HOME: ${ZSTD_HOME}")
if (NOT ZSTD_STATIC_LIB_NAME)
- set (ZSTD_STATIC_LIB_NAME ${CMAKE_STATIC_LIBRARY_PREFIX}zstd)
+ set (ZSTD_STATIC_LIB_NAME ${CMAKE_STATIC_LIBRARY_PREFIX}zstd${CMAKE_STATIC_LIBRARY_SUFFIX})
Review comment:
I understand your use case, but this is used at line 35, `find_library (ZSTD_LIBRARIES NAMES ${ZSTD_STATIC_LIB_NAME} HINTS`. Usually, `find_library` doesn't require suffix, does it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org