You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/21 11:27:25 UTC

[GitHub] [spark] valan4ik commented on pull request #29809: [SPARK-16190][CORE] Fix "Duplicate worker" error during failover

valan4ik commented on pull request #29809:
URL: https://github.com/apache/spark/pull/29809#issuecomment-696055830


   @dongjoon-hyun I don't see a way to write a test reproducing the issue itself (as there are a lot of timing and concurrency problems involved). Yet, I assume it should be possible to write a test that checks the RPC messages sent from a worker to the master and that worker reregisters only with one master in case of failover and with both masters in case of initial registration.
   
   Unfortunately, I didn't find any similar tests checking message exchanges between the worker and the master, so I may need a bit of time to figure it out 🙂


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org