[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #10007: [Bugfix](load) fix streamload failure due to false unhealthy replica in concurrent stream load

[GitBox <gi...@apache.org>]

yiguolei commented on code in PR #10007:
URL: https://github.com/apache/incubator-doris/pull/10007#discussion_r892021391


##########
be/src/agent/task_worker_pool.cpp:
##########
@@ -707,6 +708,13 @@ void TaskWorkerPool::_publish_version_worker_thread_callback() {
                 std::this_thread::sleep_for(std::chrono::seconds(1));
             }
         }
+        if (res == OLAP_ERR_ROWSET_VERSION_NOT_CONTINUOUS) {
+            std::unique_lock<std::mutex> worker_thread_lock(_worker_thread_lock);
+            // push back to task queue if publish version not continuous
+            // make sure publish version task run in order
+            _tasks.push_back(agent_task_req);

Review Comment:
   Maybe there will be a dead loop. If current tablet is a bad tablet(it really has a missed version), you will push the task to task queue and not publish it. Clone process will failed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org