You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/01/07 13:24:14 UTC

[GitHub] [couchdb] janl opened a new pull request #2411: Bypass authentication check for /_up

janl opened a new pull request #2411: Bypass authentication check for /_up
URL: https://github.com/apache/couchdb/pull/2411
 
 
   Add config variable chttpd.require_valid_user_except_for_up defaulting
   to false.
   
   This will allow various automated health check systems to hit /_up
   without having to provide a username/password pair when the
   chttpd.require_valid_user config setting is true. Apparently, many
   of these health check providers do not even allow supplying creds
   for such a purpose...
   
   Closes #823
   
   <!-- Thank you for your contribution!
   
        Please file this form by replacing the Markdown comments
        with your text. If a section needs no action - remove it.
   
        Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
        of code collaboration. Positive feedback is represented +1 from committers
        and negative is a -1. The -1 also means veto, and needs to be addressed
        to proceed. Once there are no objections, the PR can be merged by a
        CouchDB committer.
   
        See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
   
   ## Overview
   
   <!-- Please give a short brief for the pull request,
        what problem it solves or how it makes things better. -->
   
   ## Testing recommendations
   
   <!-- Describe how we can test your changes.
        Does it provides any behaviour that the end users
        could notice? -->
   
   ## Related Issues or Pull Requests
   
   <!-- If your changes affects multiple components in different
        repositories please put links to those issues or pull requests here.  -->
   
   ## Checklist
   
   - [ ] Code is written and works correctly
   - [ ] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb] janl commented on issue #2411: Bypass authentication check for /_up

Posted by GitBox <gi...@apache.org>.
janl commented on issue #2411: Bypass authentication check for /_up
URL: https://github.com/apache/couchdb/pull/2411#issuecomment-571586919
 
 
   I usually squash those on merge to master.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb] wohali merged pull request #2411: Bypass authentication check for /_up

Posted by GitBox <gi...@apache.org>.
wohali merged pull request #2411: Bypass authentication check for /_up
URL: https://github.com/apache/couchdb/pull/2411
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb] janl commented on issue #2411: Bypass authentication check for /_up

Posted by GitBox <gi...@apache.org>.
janl commented on issue #2411: Bypass authentication check for /_up
URL: https://github.com/apache/couchdb/pull/2411#issuecomment-571583966
 
 
   supersedes #856
   
   @rnewson how do you feel bout his approach?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb] janl commented on issue #2411: Bypass authentication check for /_up

Posted by GitBox <gi...@apache.org>.
janl commented on issue #2411: Bypass authentication check for /_up
URL: https://github.com/apache/couchdb/pull/2411#issuecomment-571587380
 
 
   afaict, the only merge commit that made it recently is from @kocolosk 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services