You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/04/20 02:47:06 UTC
[GitHub] [netbeans] jostle opened a new pull request #2091: NETBEANS-4192 The Gui builder uses deprecated InputEvent *_MASK constant
jostle opened a new pull request #2091:
URL: https://github.com/apache/netbeans/pull/2091
Changed usages of
InputEvent.ALT_MASK, SHIFT_MASK, CTRL_MASK and META_MASK with
InputEvent.ALT_DOWN_MASK, SHIFT_DOWN_MASK, CTRL_DOWN_MASK and META_DOWN_MASK
to avoid deprecation errors in generated code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jostle commented on pull request #2091: NETBEANS-4192 The Gui builder uses deprecated InputEvent *_MASK constant
Posted by GitBox <gi...@apache.org>.
jostle commented on pull request #2091:
URL: https://github.com/apache/netbeans/pull/2091#issuecomment-622236581
Sorry, I'm new to github process.
I have added my full name to my profile. Is that sufficient?
What should I do next?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #2091: NETBEANS-4192 The Gui builder uses deprecated InputEvent *_MASK constant
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #2091:
URL: https://github.com/apache/netbeans/pull/2091#issuecomment-624004940
Hi @jostle, I'm not very good to but may be better to redo a PR with commit having your config set
git config --global user.name "John Doe"
git config --global user.email "john@doe.org"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #2091: NETBEANS-4192 The Gui builder uses deprecated InputEvent *_MASK constant
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #2091:
URL: https://github.com/apache/netbeans/pull/2091#issuecomment-626478625
Do:
```
netbeans$ git pull
netbeans$ git checkout -f origin/master
netbeans$ git status
# everything clean, on a detached head
netbeans$ git merge --squash NETBEANS-4192_KeyEventMasks
netbeans$ git commit -m "some nice message"
netbeans$ git status
# everything clean
netbeans$ git checkout -B NETBEANS-4192_KeyEventMasks
netbeans$ git status
# your branch diverged with original/NETBEANS-4192_KeyEventMasks by N commits
netbeans$ git push -f
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jostle commented on pull request #2091: NETBEANS-4192 The Gui builder uses deprecated InputEvent *_MASK constant
Posted by GitBox <gi...@apache.org>.
jostle commented on pull request #2091:
URL: https://github.com/apache/netbeans/pull/2091#issuecomment-625791714
I'm sorry @ebarboni , I can't work out how to do that.
I've read a lot of documentation on git-scm.com, but can't get the result I expect.
I think I have spent too many decades using CVS and Subversion!
What if I create a new branch and new PR and close the current PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #2091: NETBEANS-4192 The Gui builder uses deprecated InputEvent *_MASK constant
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #2091:
URL: https://github.com/apache/netbeans/pull/2091#issuecomment-621925706
Hi @jostle we can't accept contribution as it is now You have no full name, it's a nickname for what I check.
"All commits must include the author’s full name and email address. For important modifications you will need to submit an Individual Contributor License Agreement (ICLA)."
You can see the full document here
http://netbeans.apache.org/participate/submit-pr.html#contributing-code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jostle commented on pull request #2091: NETBEANS-4192 The Gui builder uses deprecated InputEvent *_MASK constant
Posted by GitBox <gi...@apache.org>.
jostle commented on pull request #2091:
URL: https://github.com/apache/netbeans/pull/2091#issuecomment-626488133
Thanks @JaroslavTulach and @ebarboni !
That seems to have worked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jostle commented on pull request #2091: NETBEANS-4192 The Gui builder uses deprecated InputEvent *_MASK constant
Posted by GitBox <gi...@apache.org>.
jostle commented on pull request #2091:
URL: https://github.com/apache/netbeans/pull/2091#issuecomment-625241773
Thanks @ebarboni
I have pushed a new commit that, I think, should include my name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #2091: NETBEANS-4192 The Gui builder uses deprecated InputEvent *_MASK constant
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #2091:
URL: https://github.com/apache/netbeans/pull/2091#issuecomment-625247967
would be good to squash all commit in one. to avoid commit with former nickname
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists