Minor bug in Tapestry 5.5 - Could not add object with duplicate id...

[David Taylor <da...@extensiatech.com>]

It seems there is a minor problem with the changes that were made to 
configure bootstrap in Tapestry 5.5. The addCoreStylesheets method in 
JavaScriptModule is being called multiple times which has the untended 
side effect of attempting to load the Tapestry core style sheets 
multiple times. Somehow we did not spot this in the logs while testing 
the release candidate.

Since this appears to be a purely cosmetic issue, we have simply 
suppressed the warnings for now. I was contemplating submitting a pull 
request, but thought that Thiago might want to refactor the code 
himself. Please let me know if that is not the case and I would be happy 
to create a pull request.

Here are the log messages we are seeing in our spring boot logs:

2020-03-18 22:19:53.766  WARN 2316 --- [tp1817659355-19] 
o.a.t.m.J.CoreJavaScriptStack            : Could not add object with 
duplicate id 'tapestry.css'.  The duplicate object has been ignored.
2020-03-18 22:19:53.766  WARN 2316 --- [tp1817659355-19] 
o.a.t.m.J.CoreJavaScriptStack            : Could not add object with 
duplicate id 'exception-frame.css'.  The duplicate object has been ignored.
2020-03-18 22:19:53.766  WARN 2316 --- [tp1817659355-19] 
o.a.t.m.J.CoreJavaScriptStack            : Could not add object with 
duplicate id 'tapestry-console.css'.  The duplicate object has been ignored.
2020-03-18 22:19:53.766  WARN 2316 --- [tp1817659355-19] 
o.a.t.m.J.CoreJavaScriptStack            : Could not add object with 
duplicate id 'tree.css'.  The duplicate object has been ignored.
2020-03-18 22:19:53.766  WARN 2316 --- [tp1817659355-19] 
o.a.t.m.J.CoreJavaScriptStack            : Could not add object with 
duplicate id 'tapestry.css'.  The duplicate object has been ignored.
2020-03-18 22:19:53.766  WARN 2316 --- [tp1817659355-19] 
o.a.t.m.J.CoreJavaScriptStack            : Could not add object with 
duplicate id 'exception-frame.css'.  The duplicate object has been ignored.
2020-03-18 22:19:53.766  WARN 2316 --- [tp1817659355-19] 
o.a.t.m.J.CoreJavaScriptStack            : Could not add object with 
duplicate id 'tapestry-console.css'.  The duplicate object has been ignored.
2020-03-18 22:19:53.766  WARN 2316 --- [tp1817659355-19] 
o.a.t.m.J.CoreJavaScriptStack            : Could not add object with 
duplicate id 'tree.css'.  The duplicate object has been ignored.

Here is the log level change we made to suppress the warnings for now.

logging.level.org.apache.tapestry5.modules.JavaScriptModule.CoreJavaScriptStack=ERROR


Regards,

David


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org