You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/04/30 14:58:46 UTC
[GitHub] [calcite-avatica-go] huangqian1985 opened a new pull request, #60: Configurable connection parameters of httpclient
huangqian1985 opened a new pull request, #60:
URL: https://github.com/apache/calcite-avatica-go/pull/60
when i used avatica-go, i can't change the httpclient's idleConnTimeout, it is set to 90 seconds alway, in my project, i need a longer idleConnTimeout value, so i commit this pr to enable configuration some httpclient params.
The params can defined in http url params like 'maxRowsTotal' as same as before. When http params is not defines this httpclient params, they also have default value same to before.
One thing i confused is, i determine the min value of these params, but i'm not sure if I want to give a limit to the maximum value, and what should be the maximum limit for each value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite-avatica-go] F21 commented on pull request #60: Configurable connection parameters of httpclient
Posted by GitBox <gi...@apache.org>.
F21 commented on PR #60:
URL: https://github.com/apache/calcite-avatica-go/pull/60#issuecomment-1114101179
No problem at all! The link to the Go documentation was outdated. I've fixed the readme to link to the current version: https://pkg.go.dev/github.com/apache/calcite-avatica-go/v5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite-avatica-go] huangqian1985 commented on pull request #60: Configurable connection parameters of httpclient
Posted by GitBox <gi...@apache.org>.
huangqian1985 commented on PR #60:
URL: https://github.com/apache/calcite-avatica-go/pull/60#issuecomment-1114098908
Thank you for your reply, sorry for not understanding the interface very well, I will try the way you suggested, have a nice day!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite-avatica-go] F21 commented on pull request #60: Configurable connection parameters of httpclient
Posted by GitBox <gi...@apache.org>.
F21 commented on PR #60:
URL: https://github.com/apache/calcite-avatica-go/pull/60#issuecomment-1114066311
Thanks for opening this PR! I don't think we need to do this though, as the connector interface already provides the ability for you to supply your own customized `http.Client`. Another reason is that I don't think it's a good idea to include all the http connection options in the DSN as there will be a very long list of configurable options.
Would using the [`Connector`](https://pkg.go.dev/github.com/apache/calcite-avatica-go/v5@v5.1.0#Connector) work for your use case?
You can use it like this:
````go
httpClient := &http.Client{ ... }
connector := avatica.Connector{
Client: httpClient,
}
db := sql.OpenDB(connector)
err := db.Ping()
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite-avatica-go] huangqian1985 closed pull request #60: Configurable connection parameters of httpclient
Posted by GitBox <gi...@apache.org>.
huangqian1985 closed pull request #60: Configurable connection parameters of httpclient
URL: https://github.com/apache/calcite-avatica-go/pull/60
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org