You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Sushil Mohanty <su...@gmail.com> on 2017/03/23 08:53:34 UTC
Review Request 57869: LENS-1403 : Measures getting repeated in inner
select of union query
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57869/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1403
https://issues.apache.org/jira/browse/LENS-1403
Repository: lens
Description
-------
Measure columns are getting repeated if its queried multiple times in the same query eg: same measure can be part of select and having clause.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 25acb01
lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 2ca1181
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 2bf0554
lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionAndJoinCandidates.java 931f789
Diff: https://reviews.apache.org/r/57869/diff/1/
Testing
-------
Thanks,
Sushil Mohanty
Re: Review Request 57869: LENS-1403 : Measures getting repeated in
inner select of union query
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57869/#review170366
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On March 27, 2017, 4:40 p.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57869/
> -----------------------------------------------------------
>
> (Updated March 27, 2017, 4:40 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1403
> https://issues.apache.org/jira/browse/LENS-1403
>
>
> Repository: lens
>
>
> Description
> -------
>
> Measure columns are getting repeated if its queried multiple times in the same query eg: same measure can be part of select and having clause.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 25acb01
> lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 2ca1181
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 2bf0554
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionAndJoinCandidates.java 931f789
>
>
> Diff: https://reviews.apache.org/r/57869/diff/3/
>
>
> Testing
> -------
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
> Running TestSuite
>
> Tests run: 418, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 548.377 sec - in TestSuite
> Results :
> Tests run: 418, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 57869: LENS-1403 : Measures getting repeated in
inner select of union query
Posted by Sushil Mohanty <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57869/
-----------------------------------------------------------
(Updated March 27, 2017, 11:10 a.m.)
Review request for lens.
Changes
-------
- Fixed orderby clause for union queries.
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
Running TestSuite
Tests run: 418, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 468.029 sec - in TestSuite
Results :
Tests run: 418, Failures: 0, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 8:40.669s
[INFO] Finished at: Mon Mar 27 16:35:06 IST 2017
[INFO] Final Memory: 71M/1795M
[INFO] ------------------------------------------------------------------------
Bugs: LENS-1403
https://issues.apache.org/jira/browse/LENS-1403
Repository: lens
Description
-------
Measure columns are getting repeated if its queried multiple times in the same query eg: same measure can be part of select and having clause.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 25acb01
lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 2ca1181
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 2bf0554
lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionAndJoinCandidates.java 931f789
Diff: https://reviews.apache.org/r/57869/diff/3/
Changes: https://reviews.apache.org/r/57869/diff/2-3/
Testing
-------
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
Running TestSuite
Tests run: 418, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 548.377 sec - in TestSuite
Results :
Tests run: 418, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Sushil Mohanty
Re: Review Request 57869: LENS-1403 : Measures getting repeated in
inner select of union query
Posted by Sushil Mohanty <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57869/
-----------------------------------------------------------
(Updated March 24, 2017, 9:16 a.m.)
Review request for lens.
Changes
-------
- Added fix for outer having clause update for expr columns.
Bugs: LENS-1403
https://issues.apache.org/jira/browse/LENS-1403
Repository: lens
Description
-------
Measure columns are getting repeated if its queried multiple times in the same query eg: same measure can be part of select and having clause.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 25acb01
lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 2ca1181
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 2bf0554
lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionAndJoinCandidates.java 931f789
Diff: https://reviews.apache.org/r/57869/diff/2/
Changes: https://reviews.apache.org/r/57869/diff/1-2/
Testing (updated)
-------
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
Running TestSuite
Tests run: 418, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 548.377 sec - in TestSuite
Results :
Tests run: 418, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Sushil Mohanty