You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/16 11:14:51 UTC

[GitHub] [airflow] ashb opened a new pull request, #26434: Fix invalid RST in dataset concepts doc

ashb opened a new pull request, #26434:
URL: https://github.com/apache/airflow/pull/26434

   Before:
   
   ![image](https://user-images.githubusercontent.com/34150/190626807-821301c3-c455-4f61-b040-610ea04ac707.png)
   
   After:
   ![image](https://user-images.githubusercontent.com/34150/190626844-71af98c0-ab46-4d88-a85c-f6bf0c080eab.png)
   
   @ephraimbuddy @jedcunningham We should use this when building the docs for 2.4.0 (doesn't need to stop the RC vote)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb merged pull request #26434: Fix invalid RST in dataset concepts doc

Posted by GitBox <gi...@apache.org>.
ashb merged PR #26434:
URL: https://github.com/apache/airflow/pull/26434


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on a diff in pull request #26434: Fix invalid RST in dataset concepts doc

Posted by GitBox <gi...@apache.org>.
uranusjr commented on code in PR #26434:
URL: https://github.com/apache/airflow/pull/26434#discussion_r973086175


##########
docs/apache-airflow/concepts/datasets.rst:
##########
@@ -93,7 +93,7 @@ If required, an extra dictionary can be included in a Dataset:
         extra={'team': 'trainees'},
     )
 
-..note::
+.. note ::

Review Comment:
   For anyone curious: The whitespace _in front_ is significant; the one after is not.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on a diff in pull request #26434: Fix invalid RST in dataset concepts doc

Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #26434:
URL: https://github.com/apache/airflow/pull/26434#discussion_r973191706


##########
docs/apache-airflow/concepts/datasets.rst:
##########
@@ -93,7 +93,7 @@ If required, an extra dictionary can be included in a Dataset:
         extra={'team': 'trainees'},
     )
 
-..note::
+.. note ::

Review Comment:
   ❤️ RST quirks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org