RE: Review Request: Added unit test cases for api/commands

[Animesh Chaturvedi <an...@citrix.com>]

Meghna

While I was going through the review board I saw this was last updates over a month ago, Do you have any updates?

Animesh

> -----Original Message-----
> From: Rohit Yadav [mailto:noreply@reviews.apache.org] On Behalf Of Rohit
> Yadav
> Sent: Tuesday, January 08, 2013 8:20 PM
> To: Chip Childers; Prasanna Santhanam; Alex Huang; Chiradeep Vittal
> Cc: Meghna Kale; Rohit Yadav; cloudstack
> Subject: Re: Review Request: Added unit test cases for api/commands
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8355/#review15170
> -----------------------------------------------------------
> 
> 
> Heads up, going to merge api_refactoring soon so you can get started, just
> merge this on your local branch and rebase, this will save you from rewriting
> the whole tests. Then refactor such that they are under the package
> org.apache.cloudstack.api (.test ).
> 
> - Rohit Yadav
> 
> 
> On Dec. 6, 2012, 10:25 a.m., Meghna Kale wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/8355/
> > -----------------------------------------------------------
> >
> > (Updated Dec. 6, 2012, 10:25 a.m.)
> >
> >
> > Review request for cloudstack, Chip Childers, Prasanna Santhanam,
> Chiradeep Vittal, and Alex Huang.
> >
> >
> > Description
> > -------
> >
> > Added unit test cases for api/commands
> >
> >
> > Diffs
> > -----
> >
> >   api/src/com/cloud/api/commands/AssignToLoadBalancerRuleCmd.java
> 2a88e87
> >   api/src/com/cloud/api/commands/AssignVMCmd.java be28cc0
> >   api/src/com/cloud/api/commands/AssociateIPAddrCmd.java 7aaa5b5
> >   api/src/com/cloud/api/commands/AuthorizeSecurityGroupEgressCmd.java
> a6088d0
> >   api/src/com/cloud/api/commands/AuthorizeSecurityGroupIngressCmd.java
> e8f8b98
> >   api/src/com/cloud/api/commands/CreateAutoScalePolicyCmd.java 4d93747
> >   api/src/com/cloud/api/commands/CreateAutoScaleVmGroupCmd.java
> 83d7607
> >   api/src/com/cloud/api/commands/CreateAutoScaleVmProfileCmd.java
> 68c85d0
> >   api/src/com/cloud/api/commands/CreateConditionCmd.java eafd8a0
> >   api/test/src/com/cloud/api/commands/test/AddTrafficTypeCmdTest.java
> PRE-CREATION
> >
> api/test/src/com/cloud/api/commands/test/AssignToLoadBalancerRuleCmdTes
> t.java PRE-CREATION
> >   api/test/src/com/cloud/api/commands/test/AssignVMCmdTest.java PRE-
> CREATION
> >   api/test/src/com/cloud/api/commands/test/AttachIsoCmdTest.java PRE-
> CREATION
> >   api/test/src/com/cloud/api/commands/test/AttachVolumeCmdTest.java
> PRE-CREATION
> >
> api/test/src/com/cloud/api/commands/test/AuthorizeSecurityGroupEgressCmd
> Test.java PRE-CREATION
> >
> api/test/src/com/cloud/api/commands/test/AuthorizeSecurityGroupIngressCmd
> Test.java PRE-CREATION
> >
> api/test/src/com/cloud/api/commands/test/CancelMaintenanceCmdTest.java
> PRE-CREATION
> >
> api/test/src/com/cloud/api/commands/test/CancelPrimaryStorageMaintenanc
> eCmdTest.java PRE-CREATION
> >
> api/test/src/com/cloud/api/commands/test/CreateAutoScalePolicyCmdTest.jav
> a PRE-CREATION
> >
> api/test/src/com/cloud/api/commands/test/CreateAutoScaleVmGroupCmdTest
> .java PRE-CREATION
> >
> api/test/src/com/cloud/api/commands/test/CreateAutoScaleVmProfileCmdTest
> .java PRE-CREATION
> >   api/test/src/com/cloud/api/commands/test/CreateConditionCmdTest.java
> PRE-CREATION
> >   api/test/src/com/cloud/api/commands/test/CreateCounterCmdTest.java
> PRE-CREATION
> >
> > Diff: https://reviews.apache.org/r/8355/diff/
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Meghna Kale
> >
> >