[GitHub] spark pull request: [SPARK-10387][ML] Add code gen for gbt

[sethah <gi...@git.apache.org>]

Github user sethah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9524#discussion_r46749563
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
    @@ -189,6 +190,18 @@ final class GBTClassificationModel private[ml](
     
       override def treeWeights: Array[Double] = _treeWeights
     
    +  // We use two vals with options rather than lazy vals since we want
    +  // the codeGen to be eagerly evaluated.
    +  val treePredictors = useCodeGen match {
    --- End diff --
    
    Is there a reason to prefer match over if/else here? If/else seems more intuitive.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org