[GitHub] rfscholte commented on a change in pull request #2: Implement MRRESOURCES-102

[GitBox <gi...@apache.org>]

rfscholte commented on a change in pull request #2: Implement MRRESOURCES-102
URL: https://github.com/apache/maven-remote-resources-plugin/pull/2#discussion_r235874669
 
 

 ##########
 File path: src/main/java/org/apache/maven/plugin/resources/remote/ProcessRemoteResourcesMojo.java
 ##########
 @@ -944,12 +944,12 @@ private void fileWriteIfDiffers( DeferredFileOutputStream outStream )
         }
     }
 
-    private MavenFileFilterRequest setupRequest( File source, File file, boolean isFiltering )
+    private MavenFileFilterRequest setupRequest( File source, File file )
     {
         MavenFileFilterRequest req = new MavenFileFilterRequest();
         req.setFrom( source );
         req.setTo( file );
-        req.setFiltering( isFiltering );
+        req.setFiltering( true );
 
 Review comment:
   But this filtering ***always*** active, is that what we want?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services