You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by maugly24 <gi...@git.apache.org> on 2018/11/30 02:29:02 UTC
[GitHub] sqoop pull request #62: SQOOP-3415: Fixing gradle clean unittest and gradle ...
GitHub user maugly24 opened a pull request:
https://github.com/apache/sqoop/pull/62
SQOOP-3415: Fixing gradle clean unittest and gradle warning issues
(Attila Szabo)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maugly24/sqoop SQOOP-3415
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/sqoop/pull/62.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #62
----
commit 0ba740647994f5a7d0967a6404d88c06713ff8d2
Author: Attila Szabo <ma...@...>
Date: 2018-11-30T01:58:59Z
SQOOP-3415: Fixing gradle clean unittest and gradle warning issues
(Attila Szabo)
----
---
[GitHub] sqoop pull request #62: SQOOP-3415: Fixing gradle clean unittest and gradle ...
Posted by szvasas <gi...@git.apache.org>.
Github user szvasas commented on a diff in the pull request:
https://github.com/apache/sqoop/pull/62#discussion_r237896212
--- Diff: build.gradle ---
@@ -356,6 +359,15 @@ tasks.withType(Test) {
ignoreFailures ignoreTestFailures
}
+project.tasks.each {
+ if ( it.name.toLowerCase().endsWith('test') ) {
+ it.doFirst({
--- End diff --
Could we move this piece of code to the tasks.withType(Test) block so we do not have to iterate over the tasks:
```
tasks.withType(Test) {
...
doFirst {
project.mkdir(testBuildDir)
project.mkdir(testBuildDirData)
}
...
}
```
---
[GitHub] sqoop pull request #62: SQOOP-3415: Fixing gradle clean unittest and gradle ...
Posted by maugly24 <gi...@git.apache.org>.
Github user maugly24 commented on a diff in the pull request:
https://github.com/apache/sqoop/pull/62#discussion_r237962514
--- Diff: build.gradle ---
@@ -356,6 +359,15 @@ tasks.withType(Test) {
ignoreFailures ignoreTestFailures
}
+project.tasks.each {
+ if ( it.name.toLowerCase().endsWith('test') ) {
+ it.doFirst({
--- End diff --
Hi Szabi,
Thanks for the suggestion!
I've modified the build.gradle file accordingly!
---
[GitHub] sqoop pull request #62: SQOOP-3415: Fixing gradle clean unittest and gradle ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/sqoop/pull/62
---