You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "KKcorps (via GitHub)" <gi...@apache.org> on 2023/02/22 20:13:04 UTC

[GitHub] [pinot] KKcorps commented on a diff in pull request #10317: Allow file overwrite during the segment refresh for ADLS Gen2

KKcorps commented on code in PR #10317:
URL: https://github.com/apache/pinot/pull/10317#discussion_r1114906961


##########
pinot-plugins/pinot-file-system/pinot-adls/src/main/java/org/apache/pinot/plugin/filesystem/ADLSGen2PinotFS.java:
##########
@@ -630,8 +630,10 @@ private boolean copyInputStreamToDst(InputStream inputStream, URI dstUri, byte[]
     int bytesRead;
     long totalBytesRead = 0;
     byte[] buffer = new byte[BUFFER_SIZE];
+    // TODO: the newer client now has the API 'uploadFromFile' that directly takes the file as an input. We can replace

Review Comment:
   Do we need to upgrade Azure dependency to fix this TODO?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org