[GitHub] ilooner commented on a change in pull request #1351: DRILL-6543: Disable Hash Join fallback, add percent_reserved_allowance_from_direct

[GitBox <gi...@apache.org>]

ilooner commented on a change in pull request #1351: DRILL-6543: Disable Hash Join fallback, add percent_reserved_allowance_from_direct
URL: https://github.com/apache/drill/pull/1351#discussion_r199910775
 
 

 ##########
 File path: exec/java-exec/src/test/java/org/apache/drill/exec/util/TestQueryMemoryAlloc.java
 ##########
 @@ -120,6 +123,53 @@ public void testCustomPercent() throws Exception {
     }
   }
 
+  /**
+   *  Test that the percent_reserved_allowance_from_direct limitation works
+   */
+  @Test
+  public void testReservedAllowanceCheck() throws Exception {
+    OperatorFixture.Builder builder = OperatorFixture.builder(dirTestWatcher);
 
 Review comment:
   Thanks for adding a unit test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services