You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/08 19:18:26 UTC
[GitHub] [airflow] bbovenzi opened a new pull request, #24337: Add typescript
bbovenzi opened a new pull request, #24337:
URL: https://github.com/apache/airflow/pull/24337
Add typescript support for the current UI project in `/airflow/www`.
- Include type checking as part of the `yarn lint` checks
- Add example `.tsx` and `.test.tsx` files with the `Time` component and fix some associated typing issues
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on pull request #24337: Add typescript
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on PR #24337:
URL: https://github.com/apache/airflow/pull/24337#issuecomment-1150326077
> Really nice!
>
> I guess that `ts` is the new standard from now on ? (Also updating existing code each time we have the opportunity to)
Yep. That's the plan. We can migrate js files over time and across PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #24337: Add typescript
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #24337:
URL: https://github.com/apache/airflow/pull/24337#issuecomment-1150917598
🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on a diff in pull request #24337: Add typescript
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on code in PR #24337:
URL: https://github.com/apache/airflow/pull/24337#discussion_r892918569
##########
airflow/www/.eslintrc:
##########
@@ -5,6 +5,32 @@
"rules": {
Review Comment:
Added!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #24337: Add typescript
Posted by GitBox <gi...@apache.org>.
uranusjr merged PR #24337:
URL: https://github.com/apache/airflow/pull/24337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on a diff in pull request #24337: Add typescript
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on code in PR #24337:
URL: https://github.com/apache/airflow/pull/24337#discussion_r892877393
##########
airflow/www/.eslintrc:
##########
@@ -5,6 +5,32 @@
"rules": {
Review Comment:
Yeah, I was playing around with it. Let me make sure it's in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24337: Add typescript
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24337:
URL: https://github.com/apache/airflow/pull/24337#issuecomment-1151188381
Cool! Maybe finally some chance to contribute to the UI part :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #24337: Add typescript
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24337:
URL: https://github.com/apache/airflow/pull/24337#issuecomment-1150425555
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a diff in pull request #24337: Add typescript
Posted by GitBox <gi...@apache.org>.
mik-laj commented on code in PR #24337:
URL: https://github.com/apache/airflow/pull/24337#discussion_r892858304
##########
airflow/www/.eslintrc:
##########
@@ -5,6 +5,32 @@
"rules": {
Review Comment:
Should we also add [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org