[GitHub] [nifi] simonbence commented on a change in pull request #4516: NIFI-7788 Start and Stop actions on a Process Group should enable/disable transmission of RPG's

[GitBox <gi...@apache.org>]

simonbence commented on a change in pull request #4516:
URL: https://github.com/apache/nifi/pull/4516#discussion_r604064424



##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/RemoteProcessGroupResource.java
##########
@@ -829,6 +833,105 @@ public Response updateRemoteProcessGroupRunStatus(
         );
     }
 
+    /**
+     * Updates the operational status for all remote process groups in the specified process group with the specified value.
+     *
+     * @param httpServletRequest                request
+     * @param processGroupId                    The id of the process group in which all remote process groups to update.
+     * @param requestRemotePortRunStatusEntity  A remotePortRunStatusEntity that holds the desired run status
+     * @return A response with an array of RemoteProcessGroupEntity objects.
+     */
+    @PUT
+    @Consumes(MediaType.APPLICATION_JSON)
+    @Produces(MediaType.APPLICATION_JSON)
+    @Path("process-group/run-status/{id}")

Review comment:
       Minor: the URI looks like the following: `http://localhost:8888/nifi-api/remote-process-groups/process-group/run-status/82ed213b-0178-1000-f0de-db399db203fc`. Is this intentional? As the method name differs from the original by using plural, I would suggest something like: `http://localhost:8888/nifi-api/remote-process-groups/run-statuses/82ed213b-0178-1000-f0de-db399db203fc`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org