[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #12210: feat: Custom color schemes support

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210#discussion_r551557453



##########
File path: superset-frontend/src/setup/setupColors.js
##########
@@ -49,4 +50,6 @@ export default function setupColors() {
     });
   });
   sequentialSchemeRegistry.setDefaultKey('superset_seq_1');
+
+  setupColorsExtra();

Review comment:
       Should we pass the context here as in `setupColorsExtra({sequentialSchemeRegistry, categoricalSchemeRegistry});` or similar?
   
   I'm also wondering if we should have a central file for all the configuration hooks, similar to `superset/config.py` on the python side?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org