You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucy.apache.org by Marvin Humphrey <ma...@rectangular.com> on 2013/03/05 04:28:41 UTC

[lucy-dev] Re: [lucy-commits] [9/15] git commit: refs/heads/c-bindings-wip2 - Start to implement Lucy methods for C bindings

On Sat, Mar 2, 2013 at 12:06 PM,  <nw...@apache.org> wrote:
> Start to implement Lucy methods for C bindings

> Project: http://git-wip-us.apache.org/repos/asf/lucy/repo
> Commit: http://git-wip-us.apache.org/repos/asf/lucy/commit/40f7a85a
> Tree: http://git-wip-us.apache.org/repos/asf/lucy/tree/40f7a85a
> Diff: http://git-wip-us.apache.org/repos/asf/lucy/diff/40f7a85a

> +    if (fields) {
> +        hash = (lucy_Hash *)CFISH_CERTIFY(fields, LUCY_HASH);
> +        CFISH_INCREF(hash);
> +    }

For what it's worth, we could declare LUCY_USE_SHORT_NAMES at the top of each
C-specific extra implementation file.  That's left off in the analogous files
for Perl and Ruby to avoid clashes with their headers, but in the C bindings
we're only using standard C.

It's not crucial, but it's shorter.

    if (fields) {
        hash = (Hash *)CERTIFY(fields, HASH);
        INCREF(hash);
    }

Marvin Humphrey