You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by chetmurthy <gi...@git.apache.org> on 2017/11/24 02:04:51 UTC

[GitHub] thrift pull request #1417: THRIFT-4392 reorder structs in plugin.thrift

GitHub user chetmurthy opened a pull request:

    https://github.com/apache/thrift/pull/1417

    THRIFT-4392 reorder structs in plugin.thrift

    build thrift, generated ocaml from plugin.thrift, verified that compile fails.
    then applied patch, rebuild thrift, regen ocaml, recompile and compiler doesn't fail.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chetmurthy/thrift thrift-4392

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1417.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1417
    
----
commit 431efe864df62a0c8511ddc290cda5d2c062ab0f
Author: Chet Murthy <ch...@gmail.com>
Date:   2017-11-24T02:03:01Z

    THRIFT-4392 reorder structs in plugin.thrift

----


---

[GitHub] thrift pull request #1417: THRIFT-4392 reorder structs in plugin.thrift

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/1417


---