[jira] [Commented] (OAK-6297) SimpleExcerptProvider may be package private and moved to o.a.j.oak.query

["Thomas Mueller (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-6297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16038576#comment-16038576 ] 

Thomas Mueller commented on OAK-6297:
-------------------------------------

SimpleExcerptProvider is mainly a workaround to make some tests work even if Apache Lucene is not available, so I don't have strong feelings on where this class is.

But I don't understand why it's better to have this class in the query package. It is related to fulltext search, so the fulltext package sounds a bit more natural. Even thought I normally agree that things should be as close to the place as possible where they are used (allowing to make things private).

> SimpleExcerptProvider may be package private and moved to o.a.j.oak.query
> -------------------------------------------------------------------------
>
>                 Key: OAK-6297
>                 URL: https://issues.apache.org/jira/browse/OAK-6297
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, query
>            Reporter: angela
>            Priority: Minor
>         Attachments: OAK-6297.patch
>
>
> the utility {{o.a.j.oak.fulltext.SimpleExcerptProvider}} has a single usage inside the {{o.a.j.oak.query}} package space {{ResultRowImpl}}. therefore i would suggest to move it to {{o.a.j.oak.query}} and mark it package private.
> [~tmueller], i would appreciate if you could review the patch for this move.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)